From: Peter Korsgaard <jacmet@sunsite.dk>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs
Date: Wed, 17 Sep 2008 21:30:16 +0200 [thread overview]
Message-ID: <871vziwoxj.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20080917175820.GA22539@oksana.dev.rtsoft.ru> (Anton Vorontsov's message of "Wed\, 17 Sep 2008 21\:58\:20 +0400")
>>>>> "Anton" == Anton Vorontsov <avorontsov@ru.mvista.com> writes:
Hi,
Anton> This patch implements GPIOLIB support for MPC8349-compatible SOC GPIOs.
Anton> MPC8610 adopted this GPIO unit, so let's place it into sysdev.
Anton> We'll need these gpios to support IrDA transceiver on MPC8610HPCD.
It seems basically the same as my patch (gpio driver for
mpc831x/mpc834x/mpc837x with OF bindings) from September 5th except
you don't have any documentation and the Kconfig doesn't depend on
831x/834x/837x.
Galak, did you have time to look at these patches yet?
Anton> +struct fsl_gpio_chip {
Anton> + struct of_mm_gpio_chip mm_gc;
Anton> + spinlock_t lock;
Anton> +
Anton> + /* shadowed data register to clear/set bits safely */
Anton> + u32 gpdat;
Why do you need this when you have the lock?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2008-09-17 19:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 17:58 [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs Anton Vorontsov
2008-09-17 19:30 ` Peter Korsgaard [this message]
2008-09-18 11:20 ` Anton Vorontsov
2008-09-19 15:11 ` Peter Korsgaard
2008-09-19 15:33 ` Anton Vorontsov
2008-09-19 18:02 ` Kumar Gala
2008-09-19 18:12 ` Anton Vorontsov
2008-09-19 18:46 ` Kumar Gala
2008-09-21 19:30 ` Peter Korsgaard
2008-09-25 16:41 ` Scott Wood
2008-09-25 16:43 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871vziwoxj.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.