From: Andi Kleen <andi@firstfloor.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux acpi <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Holger Macht <hmacht@suse.de>, mjg59 <mjg59@srcf.ucam.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: [patch 4/11]makeing dock driver supports bay and battery hotplug
Date: Thu, 28 Aug 2008 01:13:17 +0200 [thread overview]
Message-ID: <871w0aqcfm.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1219806876.32665.60.camel@sli10-desk.sh.intel.com> (Shaohua Li's message of "Wed, 27 Aug 2008 11:14:36 +0800")
Shaohua Li <shaohua.li@intel.com> writes:
> @@ -714,6 +802,7 @@ static DEVICE_ATTR(docked, S_IRUGO, show
> static ssize_t show_flags(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> + struct dock_station *dock_station = *((struct dock_station **)dev->platform_data);
80 characters? multiple occurrences.
>
> -postcore_initcall(dock_init);
> +subsys_initcall(dock_init);
Why so early?
First that needs a comment. Also I don't understand it
(especially since it's modular too)
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-08-27 23:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 3:14 [patch 4/11]makeing dock driver supports bay and battery hotplug Shaohua Li
2008-08-27 23:13 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-08-28 2:03 Shaohua Li
2008-09-18 17:10 ` Thomas Renninger
2008-09-18 19:16 ` Thomas Renninger
2008-09-22 1:24 ` Shaohua Li
2008-09-22 9:17 ` Thomas Renninger
2008-09-22 10:58 ` Holger Macht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871w0aqcfm.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=hmacht@suse.de \
--cc=hmh@hmh.eng.br \
--cc=htejun@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.