From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KQHfx-0003Jz-1k for mharc-grub-devel@gnu.org; Tue, 05 Aug 2008 04:13:49 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQHfv-0003J9-0l for grub-devel@gnu.org; Tue, 05 Aug 2008 04:13:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQHft-0003IM-AU for grub-devel@gnu.org; Tue, 05 Aug 2008 04:13:46 -0400 Received: from [199.232.76.173] (port=43677 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQHft-0003IG-2v for grub-devel@gnu.org; Tue, 05 Aug 2008 04:13:45 -0400 Received: from smtp-vbr4.xs4all.nl ([194.109.24.24]:1642) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQHft-00086P-7t for grub-devel@gnu.org; Tue, 05 Aug 2008 04:13:45 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr4.xs4all.nl (8.13.8/8.13.8) with ESMTP id m758Dh0x033539 for ; Tue, 5 Aug 2008 10:13:43 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <87abfs32u9.fsf@xs4all.nl> Mail-Copies-To: mgerards@xs4all.nl Date: Tue, 05 Aug 2008 10:16:21 +0200 In-Reply-To: (bean123ch@gmail.com's message of "Tue, 5 Aug 2008 11:36:06 +0800") Message-ID: <871w133mi2.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] PXE support for grub2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2008 08:13:47 -0000 Bean writes: >>> +GRUB_MOD_INIT(pxe) >>> +{ >>> + (void) mod; /* To stop warning. */ >>> + >>> + grub_pxe_detect (); >>> + if (grub_pxe_pxenv) >>> + { >>> + grub_disk_dev_register (&grub_pxe_dev); >>> + grub_fs_register (&grub_pxefs_fs); >> >> filesystems belong in fs/ > > Perhaps I should place it in fs/i386/pc ? I think it would make things clearer, although I am not too sure :-) >>> +struct grub_pxenv >>> +{ >>> + grub_uint8_t signature[6]; /* 'PXENV+' */ >>> + grub_uint16_t version; /* MSB = major, LSB = minor */ >>> + grub_uint8_t length; /* structure length */ >>> + grub_uint8_t checksum; /* checksum pad */ >>> + grub_uint32_t rm_entry; /* SEG:OFF to PXE entry point */ >>> + grub_uint32_t pm_offset; /* Protected mode entry */ >>> + grub_uint16_t pm_selector; /* Protected mode selector */ >>> + grub_uint16_t stack_seg; /* Stack segment address */ >>> + grub_uint16_t stack_size; /* Stack segment size (bytes) */ >>> + grub_uint16_t bc_code_seg; /* BC Code segment address */ >>> + grub_uint16_t bc_code_size; /* BC Code segment size (bytes) */ >>> + grub_uint16_t bc_data_seg; /* BC Data segment address */ >>> + grub_uint16_t bc_data_size; /* BC Data segment size (bytes) */ >>> + grub_uint16_t undi_data_seg; /* UNDI Data segment address */ >>> + grub_uint16_t undi_data_size; /* UNDI Data segment size (bytes) */ >>> + grub_uint16_t undi_code_seg; /* UNDI Code segment address */ >>> + grub_uint16_t undi_code_size; /* UNDI Code segment size (bytes) */ >>> + grub_uint32_t pxe_ptr; /* SEG:OFF to !PXE struct */ >>> +} __attribute__ ((packed)); >> >> Can you GRUB-ify the comments here and below a bit? > > What do you mean by "GRUB-ify the comments" ? ". */ Although it is not too important for structs, I think :-) -- Marco