From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KETrE-0005iM-BU for mharc-grub-devel@gnu.org; Thu, 03 Jul 2008 14:48:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KETrC-0005hB-KP for grub-devel@gnu.org; Thu, 03 Jul 2008 14:48:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KETrA-0005fw-V8 for grub-devel@gnu.org; Thu, 03 Jul 2008 14:48:38 -0400 Received: from [199.232.76.173] (port=48446 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KETrA-0005fm-PJ for grub-devel@gnu.org; Thu, 03 Jul 2008 14:48:36 -0400 Received: from smtp-vbr7.xs4all.nl ([194.109.24.27]:4617) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KETrA-00084q-2g for grub-devel@gnu.org; Thu, 03 Jul 2008 14:48:36 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr7.xs4all.nl (8.13.8/8.13.8) with ESMTP id m63ImV99081276 for ; Thu, 3 Jul 2008 20:48:32 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1214964880.7362.17.camel@dv> <1214966028.9353.95.camel@localhost> <20080702002031.7gkuoel14wg80c0k-cebfxv@webmail.spamcop.net> <486BBEF1.6000105@nic.fi> <1215021108.29069.4.camel@dv> <87bq1e7so2.fsf@xs4all.nl> <1215109795.4585.17.camel@dv> Mail-Copies-To: mgerards@xs4all.nl Date: Thu, 03 Jul 2008 20:56:52 +0200 In-Reply-To: <1215109795.4585.17.camel@dv> (Pavel Roskin's message of "Thu, 03 Jul 2008 14:29:55 -0400") Message-ID: <871w2a6bkb.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: Eliminating grub_size_t X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2008 18:48:39 -0000 Pavel Roskin writes: > On Thu, 2008-07-03 at 20:02 +0200, Marco Gerards wrote: >> > I know what it is. I believe int should be as good as size_t for most >> > purposes is we are not working with very large structures or read >> > gigabytes of data from files at once. >> >> Perhaps, but it doesn't hurt either. I think it is a good thing to >> have a type such that it is clear what kind of variable is used. > > I mean, we can have the type, but make it 32-bit on all systems. > Anyway, the warnings have been fixed. In some cases, grub_size_t was > used for offsets, which is wrong because we want to support large files > on 32-bit systems. > > I think I'll try to make grub_size_t 32-bit everywhere and see if it's > going to make any difference or help discover some issues. Please don't. I'd rather stick to integers, such change will only slow down GRUB with no gain. -- Marco