All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Meyering <jim@meyering.net>
To: lvm-devel@redhat.com
Subject: [PATCH 2/2] Fix lv-seg relationship on layer removal
Date: Sat, 23 Feb 2008 09:44:25 +0100	[thread overview]
Message-ID: <871w74t63a.fsf@rho.meyering.net> (raw)
In-Reply-To: <47BDAF13.4040503@ce.jp.nec.com> (Jun'ichi Nomura's message of "Thu, 21 Feb 2008 12:04:19 -0500")

"Jun'ichi Nomura" <j-nomura@ce.jp.nec.com> wrote:
> When removing a layer, segments are moved from the layer LV to
> the original LV (parent).
> Before doing that, call lv_empty() to cleanup the parent and
> any relationships.
>
> Without this, the relationship between the layer_lv and parent remains
> and lvconvert will fail, for example:
>
> # lvconvert -m-1 vg/lvol0
>   LV lvol0_mimagetmp_2 used by LV lvol0:0-511, but is not listed in LV lvol0 segments list.
>   Internal error: LV segments corrupted in lvol0_mimagetmp_2.
>   intermediate VG write failed.

Hi Jun'ichi,

Would you please consider writing (or just outlining) a test case
that fails without yesterday's change, but succeeds with it?

Future maintainers will be grateful :-)



      reply	other threads:[~2008-02-23  8:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 17:04 [PATCH 2/2] Fix lv-seg relationship on layer removal Jun'ichi Nomura
2008-02-23  8:44 ` Jim Meyering [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871w74t63a.fsf@rho.meyering.net \
    --to=jim@meyering.net \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.