From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: NTFS file system driver (update 4)
Date: Thu, 02 Aug 2007 19:01:47 +0200 [thread overview]
Message-ID: <871welan0k.fsf@xs4all.nl> (raw)
In-Reply-To: <ca0f59980707311310k402a851ew9e5aac020a473ee3@mail.gmail.com> (bean123ch@gmail.com's message of "Wed, 1 Aug 2007 04:10:44 +0800")
Bean <bean123ch@gmail.com> writes:
Hi,
> I improve the driver a little bit. Now it uses grub_fshelp_read_file
> to read uncompressed files. I also disable the hook when reading
> compressed files, because disk layout doesn't make much sense for
> compressed data.
You didn't fix some issues I mentioned in my first review:
- You use u16at, etc. Can you please replace those by the matching
functions like grub_le_to_cpu16, etc?
- You have unclear errors like "B2". Can you improve those so I know
what went wrong if I get such error?
- Clean up the list of include files
Please send in attachments inline, that will make it easier to look at
and comment.
Other than these issues I see no reason why this patch can't be
committed. Can you please take care of this? Especially in the vague
error case I have no idea how I can improve this.
--
Marco
next prev parent reply other threads:[~2007-08-02 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 20:10 NTFS file system driver (update 4) Bean
2007-08-02 17:01 ` Marco Gerards [this message]
2007-08-02 18:10 ` Bean
2007-08-02 18:36 ` Marco Gerards
2007-08-02 18:52 ` Bean
2007-08-02 20:24 ` Marco Gerards
2007-08-03 2:06 ` Bean
2007-08-03 8:01 ` Marco Gerards
2007-08-03 8:36 ` Bean
2007-11-10 17:35 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871welan0k.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.