From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HjtRx-0006GN-89 for mharc-grub-devel@gnu.org; Fri, 04 May 2007 04:47:37 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HjtRY-0005uL-Lb for grub-devel@gnu.org; Fri, 04 May 2007 04:47:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HjtRW-0005sM-Aq for grub-devel@gnu.org; Fri, 04 May 2007 04:47:10 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HjtRU-0005rR-T3 for grub-devel@gnu.org; Fri, 04 May 2007 04:47:09 -0400 Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HjtKr-0005Ui-US for grub-devel@gnu.org; Fri, 04 May 2007 04:40:18 -0400 Received: from smtp-vbr12.xs4all.nl ([194.109.24.32]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HjtKr-0004HV-QU for grub-devel@gnu.org; Fri, 04 May 2007 04:40:18 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr12.xs4all.nl (8.13.8/8.13.8) with ESMTP id l448eFgQ087036; Fri, 4 May 2007 10:40:15 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20070501191808.GA19766@aragorn> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 04 May 2007 10:40:17 +0200 In-Reply-To: <20070501191808.GA19766@aragorn> (Robert Millan's message of "Tue, 1 May 2007 21:18:08 +0200") Message-ID: <871whxouby.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: FreeBSD 4.6-4.9 X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) Cc: Michael Renner Subject: Re: GPT on PC/BIOS computers X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 08:47:14 -0000 Robert Millan writes: > Here's a patch to enable GPT support for PC/BIOS systems. Need for GPT is > increasingly common due availability of > 2 TiB hard drives. > > Please let me know if everything is correct. > > Some testing would be welcome, too (but be careful, earlier versions of my > patch had a "feature" that fucked up your partition table - hopefuly fixed > now, at least Works For Me [tm]). Have you tested it on MBR? > -- > Robert Millan > > My spam trap is honeypot@aybabtu.com. Note: this address is only intended > for spam harvesters. Writing to it will get you added to my black list. > > 2007-05-01 Robert Millan > > * conf/i386-pc.rmk (grub_setup_SOURCES): Add partmap/gpt.c. > (grub_probe_SOURCES): Likewise. > * conf/i386-pc.mk: Regenerate. No need to mention this. > * util/i386/pc/biosdisk.c (grub_util_biosdisk_get_grub_dev): Detect > GPT and initialize dos_part and bsd_part accordingly. > * util/i386/pc/grub-setup.c: Ditto for install_dos_part and > install_bsd_part. > * util/i386/pc/grub-install.in: Add gpt module to core.img. > * util/i386/pc/grub-probe.c: Activate gpt module for use during > partition identification, and deactivate it afterwards. > * util/i386/pc/grub-setup.c: Ditto. You don't mention in which function you do these things, just the files. Can you correct this? I personally would prefer if you do not split up the changelog entries for one file, perhaps it is not even allowed by the GCS. > Index: util/i386/pc/grub-install.in > =================================================================== > RCS file: /sources/grub/grub2/util/i386/pc/grub-install.in,v > retrieving revision 1.11 > diff -u -r1.11 grub-install.in > --- util/i386/pc/grub-install.in 10 Apr 2007 21:38:26 -0000 1.11 > +++ util/i386/pc/grub-install.in 1 May 2007 18:56:07 -0000 > @@ -216,8 +216,8 @@ > exit 1 > fi > > -# Typically, _chain and pc are required. > -modules="$modules $fs_module _chain pc" > +# Typically, _chain, pc and gpt are required. > +modules="$modules $fs_module _chain pc gpt" It would be nice if we were able to use grub-probe to determine this... But for now this is fine, I think. -- Marco