All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Rydberg <jrydberg@night.trouble.net>
To: grub-devel@gnu.org
Subject: Let core developers "vote" to accept patches.
Date: Tue, 15 Aug 2006 00:37:23 +0200	[thread overview]
Message-ID: <871wrjhrks.fsf@night.trouble.net> (raw)

Hi,

In other projects that I've worked on, we've used a system where the
core developers can either give a +1 or a -1 on a contributed patch.
If a patch receives two +1's or more, it is accepted (if there are no
-1's) and committed by one of the developers.  

This lowers the pressure on the maintainers, and hopefully will speed
up the development.

Though, the core developers need to be a bit careful.  They should not
give +1's or -1's on a patch that they either (1) do not fully
understand, or that (2) applies to a section of the code that they are
not knowledgeable about.  It is then better to either state that they
do not know the area well enough, and maybe give the patch a +0, or be
silent.  

The downside is that some developers will never feel that they are
knowledgeable enough to comment on a contribution; resulting in that
the maintainer will have to do it.  The same situation we are in now,
more or less.

The upside is that the maintainers can focus on other things than just
reviewing patches; maybe getting some new features in.  Also, trivial
and small patches will get quicker review and get merged into the tree
in a swift manner.


Please note:

This is in no way an attempt to overrun any of our maintainers, it is
just an attempt to make things go a bit smoother and faster in the
times when the maintainers are busy with other things.

Please note:

I'm not saying I'm in any way a core developer, just sharing my
experiences from other projects.

Okuji, Marco, others; comments?

~j





             reply	other threads:[~2006-08-14 22:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-14 22:37 Johan Rydberg [this message]
2006-08-15  0:27 ` Let core developers "vote" to accept patches Hollis Blanchard
2006-08-15  9:20 ` Marco Gerards
2006-08-15 12:42 ` Yoshinori K. Okuji
2006-08-15 13:26   ` Johan Rydberg
2006-08-21 13:14 ` Jeff Bailey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871wrjhrks.fsf@night.trouble.net \
    --to=jrydberg@night.trouble.net \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.