arch-specific files

arch-specific files

[Yoshinori K. Okuji]

Hollis put ieee1275.c under the directory kern directly, and I don't feel 
comfortable with this. Even if that file is shared by multiple cpu types, it 
is still arch-dependent.

I'm thinking what directory should be used for this. Usually, we use 
CPU/PLATFORM, so these are possible:

generic/ieee1275
common/ieee1275
any/ieee1275

I don't know which is good. What is your opinion?

Okuji

Re: arch-specific files

[Yoshinori K. Okuji]

On Saturday 06 August 2005 17:04, Yoshinori K. Okuji wrote:
> Hollis put ieee1275.c under the directory kern directly, and I don't feel
> comfortable with this. Even if that file is shared by multiple cpu types,
> it is still arch-dependent.
>
> I'm thinking what directory should be used for this. Usually, we use
> CPU/PLATFORM, so these are possible:
>
> generic/ieee1275
> common/ieee1275
> any/ieee1275
>
> I don't know which is good. What is your opinion?

For now, I just put it in kern/ieee1275.

Okuji

Re: arch-specific files

[Hollis Blanchard]

On Aug 7, 2005, at 9:15 AM, Yoshinori K. Okuji wrote:

> On Saturday 06 August 2005 17:04, Yoshinori K. Okuji wrote:
>> Hollis put ieee1275.c under the directory kern directly, and I don't 
>> feel
>> comfortable with this. Even if that file is shared by multiple cpu 
>> types,
>> it is still arch-dependent.
>>
>> I'm thinking what directory should be used for this. Usually, we use
>> CPU/PLATFORM, so these are possible:
>>
>> generic/ieee1275
>> common/ieee1275
>> any/ieee1275
>>
>> I don't know which is good. What is your opinion?
>
> For now, I just put it in kern/ieee1275.

Since "of" is a very common English word, it is not a good file or 
variable name. We have standardized on the full "ieee1275" for both, so 
I have renamed this file.

-Hollis

Re: arch-specific files

[Yoshinori K. Okuji]

On Tuesday 09 August 2005 05:37, Hollis Blanchard wrote:
> Since "of" is a very common English word, it is not a good file or
> variable name. We have standardized on the full "ieee1275" for both, so
> I have renamed this file.

OK. That makes sense. Just a question: why do we still use "of" in some places 
then? Like ofconsole.c. Why isn't it just console.c?

Okuji

Re: arch-specific files

[Marco Gerards]

"Yoshinori K. Okuji" <okuji@enbug.org> writes:

> On Tuesday 09 August 2005 05:37, Hollis Blanchard wrote:
>> Since "of" is a very common English word, it is not a good file or
>> variable name. We have standardized on the full "ieee1275" for both, so
>> I have renamed this file.
>
> OK. That makes sense. Just a question: why do we still use "of" in some places 
> then? Like ofconsole.c. Why isn't it just console.c?

It can be renamed if you think it is important..  I have chosen this
name in case another type of console is required for powerpc/ieee1275.
For example on the old world mac there is no console support in open
firmware AFAIK.  But the old world port related things do belong in
powerpc/ieee1275.

--
Marco

Re: arch-specific files

[Hollis Blanchard]

On Aug 9, 2005, at 8:23 AM, Marco Gerards wrote:

> "Yoshinori K. Okuji" <okuji@enbug.org> writes:
>
>> On Tuesday 09 August 2005 05:37, Hollis Blanchard wrote:
>>> Since "of" is a very common English word, it is not a good file or
>>> variable name. We have standardized on the full "ieee1275" for both, 
>>> so
>>> I have renamed this file.
>>
>> OK. That makes sense. Just a question: why do we still use "of" in 
>> some places
>> then? Like ofconsole.c. Why isn't it just console.c?
>
> It can be renamed if you think it is important..  I have chosen this
> name in case another type of console is required for powerpc/ieee1275.
> For example on the old world mac there is no console support in open
> firmware AFAIK.  But the old world port related things do belong in
> powerpc/ieee1275.

That's not true; Old World Macs do have some sort of console support. 
The problems are varied: some systems don't have a working video driver 
(but if you know what you're doing, you can use the serial ports). 
Other systems default to the serial ports, so a user expecting an 
interface on their monitor will be disappointed. But technically these 
are not console driver issues.

I agree that "ofconsole" is named inconsistently.

-Hollis

Re: arch-specific files

[Marco Gerards]

Hollis Blanchard <hollis@penguinppc.org> writes:

>>> OK. That makes sense. Just a question: why do we still use "of" in
>>> some places
>>> then? Like ofconsole.c. Why isn't it just console.c?
>>
>> It can be renamed if you think it is important..  I have chosen this
>> name in case another type of console is required for powerpc/ieee1275.
>> For example on the old world mac there is no console support in open
>> firmware AFAIK.  But the old world port related things do belong in
>> powerpc/ieee1275.
>
> That's not true; Old World Macs do have some sort of console
> support. The problems are varied: some systems don't have a working
> video driver (but if you know what you're doing, you can use the
> serial ports). Other systems default to the serial ports, so a user
> expecting an interface on their monitor will be disappointed. But
> technically these are not console driver issues.

With no console support I meant no console support on the monitor.

--
Marco