From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] rte_eth_af_packet: refactor error handling to avoid NULL pointer dereference
Date: Tue, 20 Oct 2015 09:02:04 -0700 (PDT) [thread overview]
Message-ID: <8727896.bTnbiDNnpp@xps13> (raw)
In-Reply-To: <20150828102742.GA3351@hmsreliant.think-freely.org>
2015-08-28 06:27, Neil Horman:
> On Thu, Aug 27, 2015 at 01:17:13PM -0400, John W. Linville wrote:
> > Coverity CID # 13321
> >
> > Checking *internals != NULL before accessing req is not good enough,
> > because **internals is a function argument and the function doesn't
> > really know what is passed-in. We can close our eyes and ignore the
> > warning on the basis of controlling all the calling code, or we can
> > refactor the error exit to avoid the issue entirely...
> >
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Applied, thanks
prev parent reply other threads:[~2015-10-20 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 17:17 [PATCH] rte_eth_af_packet: refactor error handling to avoid NULL pointer dereference John W. Linville
2015-08-28 10:27 ` Neil Horman
2015-10-20 16:02 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8727896.bTnbiDNnpp@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.