From: Takashi Iwai <tiwai@suse.de>
To: Sungwoo Kim <iam@sung-woo.kim>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Dave Tian <daveti@purdue.edu>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] ALSA: hda/realtek: fix missing chained flag in fixup
Date: Mon, 16 Nov 2026 13:25:03 +0100 [thread overview]
Message-ID: <8733t1ynds.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261115132215.4084031-2-iam@sung-woo.kim>
On Sun, 15 Nov 2026 14:22:15 +0100,
Sungwoo Kim wrote:
>
> The fixup specifies a chain_id but does not set the chained flag,
> which prevents the chained fixup from being executed.
>
> Should chained be set to true here?
>
> This was identified through static analysis and has not been tested
> on actual hardware.
>
> Signed-off-by: Sungwoo Kim <iam@sung-woo.kim>
Interesting, and yes, the flag should have been set to make the
chain_id effective. OTOH, those entries are all pin-config updates
for Loongson & co, and ALC269_FIXUP_DMIC is also the pin-config
update, so I guess your change is superfluous or breaking.
I'd rather delete or comment out those dead lines unless anyone
actually hitting the problem, instead.
thanks,
Takashi
> ---
> sound/hda/codecs/realtek/alc269.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 96fa8c2782bb..1be2e609c28d 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -6431,6 +6431,7 @@ static const struct hda_fixup alc269_fixups[] = {
> { 0x1e, 0x411111f0 },
> { }
> },
> + .chained = true,
> .chain_id = ALC269_FIXUP_DMIC,
> },
> [ALC269_FIXUP_CZC_TMI] = {
> @@ -6449,6 +6450,7 @@ static const struct hda_fixup alc269_fixups[] = {
> { 0x20, 0x8000ffff },
> { }
> },
> + .chained = true,
> .chain_id = ALC269_FIXUP_DMIC,
> },
> [ALC269_FIXUP_CZC_L101] = {
> @@ -6467,6 +6469,7 @@ static const struct hda_fixup alc269_fixups[] = {
> { 0x1e, 0x411111f0 },
> { }
> },
> + .chained = true,
> .chain_id = ALC269_FIXUP_DMIC,
> },
> [ALC269_FIXUP_LEMOTE_A1802] = {
> @@ -6485,6 +6488,7 @@ static const struct hda_fixup alc269_fixups[] = {
> { 0x21, 0x03214020 },
> { }
> },
> + .chained = true,
> .chain_id = ALC269_FIXUP_DMIC,
> },
> [ALC269_FIXUP_LEMOTE_A190X] = {
> @@ -6497,6 +6501,7 @@ static const struct hda_fixup alc269_fixups[] = {
> { 0x1b, 0x0201401f }, /* front lineout */
> { }
> },
> + .chained = true,
> .chain_id = ALC269_FIXUP_DMIC,
> },
> [ALC256_FIXUP_INTEL_NUC8_RUGGED] = {
> --
> 2.47.3
>
prev parent reply other threads:[~2026-11-16 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 13:22 [RFC PATCH] ALSA: hda/realtek: fix missing chained flag in fixup Sungwoo Kim
2026-11-15 13:26 ` Sungwoo Kim
2026-11-15 13:35 ` Sungwoo Kim
2026-11-15 13:32 ` sashiko-bot
2026-11-16 12:25 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8733t1ynds.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=daveti@purdue.edu \
--cc=iam@sung-woo.kim \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.