From: Petr Machata <petrm@nvidia.com>
To: Hannes Laimer <h.laimer@proxmox.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>,
David Ahern <dsahern@kernel.org>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH net 1/2] vxlan: keep reserved_bits across changelink
Date: Mon, 26 Oct 2026 10:52:19 +0100 [thread overview]
Message-ID: <8733ts6b70.fsf@pmachata.org> (raw)
In-Reply-To: <20261023-b4-vxlan-changelink-gbp-v1-1-f0d13951c09b@proxmox.com> (Hannes Laimer's message of "Fri, 23 Oct 2026 13:14:27 +0200")
Hannes Laimer <h.laimer@proxmox.com> writes:
> vxlan_nl2conf() derives reserved_bits from the extension attributes
> set in the netlink message if IFLA_VXLAN_RESERVED_BITS is absent. A
> changelink having it set is rejected, so this means that every
> changelink will reset all extension bits and reserve them again.
> vxlan_nl2flag() rejects setting a flag on an attribute that is
> create-only on changelink. So also setting an extension attribute will
> fail before it can un-reserve its fields.
> Keeping the reserved_bits on changelink is safe because anything a
> changelink accepts leaves the header bits enabled extensions use
> unchanged.
> Fixes: e4f8647767cf ("vxlan: Track reserved bits explicitly as part of the configuration")
> Link: https://lore.proxmox.com/pve-devel/20260828134708.692354-1-h.laimer@proxmox.com/
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
next prev parent reply other threads:[~2026-10-26 9:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 11:14 [PATCH net 0/2] vxlan: keep reserved_bits on changelink Hannes Laimer
2026-10-23 11:14 ` [PATCH net 1/2] vxlan: keep reserved_bits across changelink Hannes Laimer
2026-10-26 7:58 ` Nikolay Aleksandrov
2026-10-26 9:52 ` Petr Machata [this message]
2026-10-23 11:14 ` [PATCH net 2/2] selftests: forwarding: vxlan_reserved: add gbp changelink test Hannes Laimer
2026-10-26 7:58 ` Nikolay Aleksandrov
2026-10-26 9:52 ` Petr Machata
2026-10-23 14:57 ` [PATCH net 0/2] vxlan: keep reserved_bits on changelink Gabriel Goller
2026-10-26 5:36 ` Hangbin Liu
2026-10-27 10:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8733ts6b70.fsf@pmachata.org \
--to=petrm@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=h.laimer@proxmox.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.