From: Luis Henriques <luis@igalia.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fuse: rename fuse_direct_io() to fuse_sync_direct_io()
Date: Thu, 15 Oct 2026 18:23:13 +0100 [thread overview]
Message-ID: <8733u6j2ta.fsf@igalia.com> (raw)
In-Reply-To: <CAJfpegvdnPeyp8MYz9Y+v-nKNAj-J9N=nFyELfbB79nQJUiRQA@mail.gmail.com>
On Thu, Oct 15 2026, Miklos Szeredi wrote:
> On Fri, 4 Sept 2026 at 15:17, Luis Henriques <luis@igalia.com> wrote:
>>
>> FUSE has two functions with very similar name: fuse_direct_io() and
>> fuse_direct_IO(). Which is very confusing. Rename one of them to remove
>> the ambiguity.
>
> Intention is good, but fuse_sync_direct_io() is not the best name,
> because it's used for both sync and async direct IO.
>
> How about fuse_do_direct_io()?
OK, thanks for the suggestion. I'll respin this patch with that name
instead.
Cheers,
--
Luís
prev parent reply other threads:[~2026-10-15 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 13:18 [PATCH] fuse: rename fuse_direct_io() to fuse_sync_direct_io() Luis Henriques
2026-10-15 12:08 ` Miklos Szeredi
2026-10-15 17:23 ` Luis Henriques [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8733u6j2ta.fsf@igalia.com \
--to=luis@igalia.com \
--cc=fuse-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.