Re: [PATCH v3] uniwill: Add support for MECHREVO WUJIE Series 15 X Pro

[Donjuanplatinum <donplat@barrensea.org>]

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

Armin Wolf <W_Armin@gmx.de> writes:

>
> Hi,
>
> please remove this pointless block of text.

OK, I've remove it.

>
> Can you check if UNIWILL_FEATURE_BATTERY_CHARGE_MODES also works on your device?
> Please note that the embedded controller will still report to charge the battery
> to 100%, so this is not a reliable indicator. Do you know if the Windows OEM app
> provides such a setting on this device?
>
> Thanks,
> Armin Wolf
>

I also checked the battery charge modes in the Windows OEM application. The OEM application provides this setting.

Additionally, I used the interfaces exposed by the OEM's
ACPIDriverDll.dll to test the three charge modes and confirmed that
their behavior matches the current implementation in the Uniwill driver.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-uniwill-Add-support-for-MECHREVO-WUJIE-Series-15-X-P.patch --]
[-- Type: text/x-patch, Size: 2028 bytes --]

From 518d89d58e3ea84af4bced696150ca1e02a4575c Mon Sep 17 00:00:00 2001
From: Donjuanplatinum <donplat@barrensea.org>
Date: Tue, 29 Sep 2026 01:29:09 +0800
Subject: [PATCH v3] platform/x86: uniwill-laptop: Add support for
MECHREVO WUJIE Series 15 X Pro

Add support for the MECHREVO WUJIE Series 15 X Pro (WUJIE
Series-X5SP4NAG).

Signed-off-by: Yifei Yao <donplat@barrensea.org>
---
 drivers/platform/x86/uniwill/uniwill-acpi.c | 22 +++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c
index 7a2eeaec4c96..bf46f03fb5f5 100644
--- a/drivers/platform/x86/uniwill/uniwill-acpi.c
+++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
@@ -2712,6 +2712,20 @@ static struct uniwill_device_descriptor lapkc71f_descriptor __initdata = {
 	.lightbar_max_brightness = 200,
 };
 
+static struct uniwill_device_descriptor series_x5sp4nag_descriptor __initdata = {
+	.features = UNIWILL_FEATURE_FN_LOCK |
+		    UNIWILL_FEATURE_SUPER_KEY |
+		    UNIWILL_FEATURE_CPU_TEMP |
+		    UNIWILL_FEATURE_PRIMARY_FAN |
+		    UNIWILL_FEATURE_SECONDARY_FAN |
+	            UNIWILL_FEATURE_BATTERY_CHARGE_MODES |
+		    UNIWILL_FEATURE_KEYBOARD_BACKLIGHT |
+		    UNIWILL_FEATURE_AC_AUTO_BOOT |
+		    UNIWILL_FEATURE_USB_POWERSHARE,
+	.kbd_led_single_color = false,
+	.kbd_led_max_brightness = 4,
+};
+
 /*
  * The featuresets below reflect somewhat chronological changes:
  * 1 -> 2: UNIWILL_FEATURE_NVIDIA_CTGP_CONTROL is added to the EC firmware.
@@ -2996,6 +3010,14 @@ static const struct dmi_system_id uniwill_dmi_table[] __initconst = {
 		},
 		.driver_data = &tux_featureset_4_descriptor,
 	},
+	{
+		.ident = "MECHREVO WUJIE Series 15 X Pro",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "MECHREVO"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "WUJIE Series-X5SP4NAG"),
+		},
+		.driver_data = &series_x5sp4nag_descriptor,
+	},
 	{
 		.ident = "TUXEDO InfinityBook Pro 14/15 Gen9 Intel/Commodore Omnia-Book 15 Gen9",
 		.matches = {
-- 
2.55.0