All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: sashiko-bot@kernel.org
Cc: "Zongzhen Feng" <1768315307@qq.com>,
	 "Vignesh Raghavendra" <vigneshr@ti.com>,
	 sashiko-reviews@lists.linux.dev, linux-kernel@vger.kernel.org,
	 linux-mtd@lists.infradead.org,
	 "Richard Weinberger" <richard@nod.at>
Subject: Re: [PATCH v4] mtd: spinand: cache the last read page to avoid redundant SPI operations
Date: Thu, 10 Sep 2026 14:42:15 +0200	[thread overview]
Message-ID: <8733vhs2fs.fsf@bootlin.com> (raw)
In-Reply-To: <20260910042619.2A3731F000FF@smtp.kernel.org> (sashiko-bot@kernel.org's message of "Thu, 10 Sep 2026 04:26:18 +0000")

Hi Zongzhen,

On 10/09/2026 at 04:26:18 GMT, sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
> - [Critical] Partial page reads with software/host ECC cause silent data corruption on subsequent cache hits due to incomplete cache updates.
> - [Critical] Cache hit logic fails to check the Logical Unit Number (LUN), leading to cross-LUN cache aliasing.
> - [High] Missing cache invalidation on OOB/OTP writes causes cached reads to return clobbered data.
> - [High] Error handling leaves cache valid with uncorrected data on
> non-EBADMSG errors.

These still seem valid :-)

Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2026-09-10 12:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08  3:25 [PATCH v2] mtd: spinand: cache the last read page to avoid redundant SPI operations fzz
2026-09-08  9:39 ` Miquel Raynal
2026-09-08 10:28   ` Zongzhen Feng
2026-09-08 10:19 ` [PATCH v3] " Zongzhen Feng
2026-09-08 14:22   ` Miquel Raynal
2026-09-09  6:29     ` Zongzhen Feng
2026-09-09  7:46       ` Miquel Raynal
2026-09-10  4:08   ` [PATCH v4] " Zongzhen Feng
2026-09-10  4:26     ` sashiko-bot
2026-09-10 12:42       ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8733vhs2fs.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=1768315307@qq.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.