From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D92C6433E75 for ; Fri, 3 Jul 2026 21:40:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=166.70.13.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783114809; cv=none; b=PC+Vv8VyeUffIvQOLFcUz9HTrFbGNEQG4GoRk3k70xW3eEFfn7b3WD3YyCEGohJG/agiJhmYtlO+h4RKeh86L2FtqKpR10SHVlOnmNFkbVwoiaXKbW3GgkjbUwSQgEHWcAjB1begHxOxBfhpsZ/uPLMquODx2eSS15ZziFg6T2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783114809; c=relaxed/simple; bh=5/VgvBPTqC9hLlB7ugeX+50xS+UkWCc9nmqpzkltSkc=; h=From:To:Cc:In-Reply-To:References:Date:Message-ID:MIME-Version: Content-Type:Subject; b=jLwWlsTe92XOpHI6Cpw645lOa84Meto7FlB3wc80P9FYftBqiRxQ2nRg2y5yTM1Hf9ZUpMeVjrH7bic5SONGQtBlg3fqpeb2cWivYAd8bb7tW/82M/YL4z569orz4IAbsK+wdiLoZxsgZ60qILHL8FhLS4BlP12VTkVR6KhVN+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xmission.com; spf=pass smtp.mailfrom=xmission.com; dkim=pass (1024-bit key) header.d=xmission.com header.i=@xmission.com header.b=dfCaXyH1; arc=none smtp.client-ip=166.70.13.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xmission.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xmission.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xmission.com header.i=@xmission.com header.b="dfCaXyH1" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=xmission.com; s=xmission; h=Subject:Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5/VgvBPTqC9hLlB7ugeX+50xS+UkWCc9nmqpzkltSkc=; b=dfCaXyH1T6DYqLC00FpQKllCuV bpXwEoT8vxJ/8IEIgkAKVM8CZY47urMNabvJkdw2qc2KZqpyzl+pwN+rYGjk3jZNY9M1r9mZaZHkC LXCCM6/oicqlFLaPyVBN5hHT8iUNXE1ZKZxWdXC1zFH9fFlWUv66dQIkICLwmVcPT0mA=; Received: from in01.mta.xmission.com ([166.70.13.51]:57350) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1wflcF-003GB3-37; Fri, 03 Jul 2026 15:40:07 -0600 Received: from ip72-198-198-28.om.om.cox.net ([72.198.198.28]:36190 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1wflcE-00DmHl-79; Fri, 03 Jul 2026 15:40:06 -0600 From: "Eric W. Biederman" To: Oleg Nesterov Cc: Andrew Morton , Andy Lutomirski , Kees Cook , Kusaram Devineni , Peter Zijlstra , Thomas Gleixner , Will Drewry , linux-kernel@vger.kernel.org, Linus Torvalds , Christian Brauner In-Reply-To: <877bnb4uyw.fsf_-_@email.froward.int.ebiederm.org> (Eric W. Biederman's message of "Fri, 03 Jul 2026 16:35:51 -0500") References: <87o6gx9rc4.fsf@email.froward.int.ebiederm.org> <877bnh7tnf.fsf@email.froward.int.ebiederm.org> <877bnb4uyw.fsf_-_@email.froward.int.ebiederm.org> Date: Fri, 03 Jul 2026 16:40:00 -0500 Message-ID: <8733xz3g7j.fsf_-_@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1wflcE-00DmHl-79;;;mid=<8733xz3g7j.fsf_-_@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=72.198.198.28;;;frm=ebiederm@xmission.com;;;sPfnum=0;;;sPf=pass X-XM-AID: U2FsdGVkX1/iDC0Z1zPcHfJAEwwHDQ6soAA75JriDVU= X-Spam-Level: * X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.1 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; Body=1 Fuz1=1 Fuz2=48] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa04 1397; Body=1 Fuz1=1 Fuz2=48 X-Spam-Combo: *;Oleg Nesterov X-Spam-Relay-Country: X-Spam-Timing: total 422 ms - load_scoreonly_sql: 0.05 (0.0%), signal_user_changed: 10 (2.4%), b_tie_ro: 9 (2.1%), parse: 0.82 (0.2%), extract_message_metadata: 9 (2.2%), get_uri_detail_list: 1.15 (0.3%), tests_pri_-2000: 11 (2.6%), tests_pri_-1000: 2.3 (0.5%), tests_pri_-950: 1.01 (0.2%), tests_pri_-900: 0.79 (0.2%), tests_pri_-90: 50 (11.8%), check_bayes: 48 (11.5%), b_tokenize: 6 (1.4%), b_tok_get_all: 5 (1.2%), b_comp_prob: 1.64 (0.4%), b_tok_touch_all: 33 (7.8%), b_finish: 0.71 (0.2%), tests_pri_0: 323 (76.6%), check_dkim_signature: 1.07 (0.3%), check_dkim_adsp: 3.0 (0.7%), poll_dns_idle: 0.67 (0.2%), tests_pri_10: 2.1 (0.5%), tests_pri_500: 9 (2.2%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH 06/14] signal: In get_signal call do_exit when it is unnecessary to shoot down threads X-SA-Exim-Connect-IP: 166.70.13.51 X-SA-Exim-Rcpt-To: brauner@kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, wad@chromium.org, tglx@kernel.org, peterz@infradead.org, kusaram@devineni.in, kees@kernel.org, luto@kernel.org, akpm@linux-foundation.org, oleg@redhat.com X-SA-Exim-Mail-From: ebiederm@xmission.com X-SA-Exim-Scanned: No (on out02.mta.xmission.com); SAEximRunCond expanded to false In get_signal if other threads of the current process do not need to be shot down calling do_group_exit is equivalent to calling do_exit. The code in get_signal is only responsible for shooting down threads when it dequeues a signal and decides the signal is fatal. To remove special cases and make the code easier to read, call do_exit instead of do_group_exit when no other threads need to be shot down. With do_group_exit no longer being called when exec is terminating threads in de_thread remove the special case in do_group_exit for handling exec. Signed-off-by: "Eric W. Biederman" --- kernel/exit.c | 4 ---- kernel/signal.c | 7 ++++++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/kernel/exit.c b/kernel/exit.c index c8460c215189..55f03477cb08 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1125,8 +1125,6 @@ do_group_exit(int exit_code) if (sig->flags & SIGNAL_GROUP_EXIT) exit_code = sig->group_exit_code; - else if (sig->group_exec_task) - ; else { struct sighand_struct *const sighand = current->sighand; @@ -1134,8 +1132,6 @@ do_group_exit(int exit_code) if (sig->flags & SIGNAL_GROUP_EXIT) /* Another thread got here before we took the lock. */ exit_code = sig->group_exit_code; - else if (sig->group_exec_task) - ; else { sig->group_exit_code = exit_code; sig->flags = SIGNAL_GROUP_EXIT; diff --git a/kernel/signal.c b/kernel/signal.c index 0e9103bda143..94662010ab4c 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -2906,6 +2906,7 @@ bool get_signal(struct ksignal *ksig) } for (;;) { + bool group_exit_needed = false; struct k_sigaction *ka; enum pid_type type; int exit_code = 0; @@ -3048,6 +3049,7 @@ bool get_signal(struct ksignal *ksig) * Anything else is fatal, maybe with a core dump. */ exit_code = signr; + group_exit_needed = true; fatal: spin_unlock_irq(&sighand->siglock); if (unlikely(cgroup_task_frozen(current))) @@ -3082,7 +3084,10 @@ bool get_signal(struct ksignal *ksig) /* * Death signals, no core dump. */ - do_group_exit(exit_code); + if (group_exit_needed) + do_group_exit(exit_code); + else + do_exit(exit_code); /* NOTREACHED */ } spin_unlock_irq(&sighand->siglock); -- 2.41.0