Re: [PATCH 1/5] qemu-options: fix missing addr. prefix on -netdev stream inet/unix options

[Markus Armbruster <armbru@redhat.com>]

Mitsuru Kariya <Mitsuru.Kariya@oss.nttdata.com> writes:

> -netdev stream uses modern syntax parsed by netdev_parse_modern() which
> goes through the QAPI keyval visitor (qobject_input_visitor_new_str() ->
> keyval_parse() -> qobject_input_visitor_new_keyval() -> visit_type_Netdev()).
> Options nested under addr (of type SocketAddress) must therefore be
> written with the "addr." prefix: a top-level "keep-alive=on" is rejected
> by the QAPI input visitor with "Parameter 'keep-alive' is unexpected",
> because NetdevStreamOptions has no such member.
>
> The documentation listed several InetSocketAddress members (to, numeric,
> keep-alive, mptcp, ipv4, ipv6) and UnixSocketAddress members (abstract,
> tight) without the prefix, which never actually worked.  Only
> addr.type/addr.host/addr.port/addr.path/addr.str were spelled correctly
> in the synopsis.
>
> Add the missing addr. prefix to all affected option names.
>
> Fixes: bb1326abd9df ("net: update netdev stream/dgram man page")
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Mitsuru Kariya <Mitsuru.Kariya@oss.nttdata.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>