From: Thomas Gleixner <tglx@kernel.org>
To: Sascha Bischoff <Sascha.Bischoff@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: nd <nd@arm.com>, Lorenzo Pieralisi <lpieralisi@kernel.org>,
Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH 1/3] irqchip/gic-v5: Move LPI alloc/free into LPI domain
Date: Tue, 05 May 2026 22:02:43 +0200 [thread overview]
Message-ID: <873405y68s.ffs@tglx> (raw)
In-Reply-To: <20260430153352.3654325-2-sascha.bischoff@arm.com>
On Thu, Apr 30 2026 at 15:34, Sascha Bischoff wrote:
> Rather than relying on the domains built on top of GICv5's LPI domain
> to manage LPI allocations and frees, move that into the LPI domain
> itself. This, rightly, ensures that domains other than the LPI itself
> have no knowledge of LPI allocations themselves. This not only cleans
> up the LPI domain itself, but also the IPI and ITS MSI domains which
> build upon it.
>
> While we're at it, drop the helpers wrapping the helpers -
> gicv5_alloc_lpi() and gicv5_free_lpi() - and directly use alloc_lpi()
> and release_lpi() instead.
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#changelog
>
> +static void gicv5_irq_lpi_domain_free(struct irq_domain *domain, unsigned int virq,
> + unsigned int nr_irqs)
> +{
> + struct irq_data *d;
> +
> + if (WARN_ON_ONCE(nr_irqs != 1))
> + return;
> +
> + d = irq_domain_get_irq_data(domain, virq);
> +
> +
Stray extra newline.
> + release_lpi(d->hwirq);
> +
> + irq_set_handler(virq, NULL);
> + irq_domain_reset_irq_data(d);
> +}
Otherwise this looks good.
next prev parent reply other threads:[~2026-05-05 20:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 15:33 [PATCH 0/3] irqchip/gic-v5: Tidy up LPI allocation Sascha Bischoff
2026-04-30 15:34 ` [PATCH 1/3] irqchip/gic-v5: Move LPI alloc/free into LPI domain Sascha Bischoff
2026-05-05 20:02 ` Thomas Gleixner [this message]
2026-05-06 9:35 ` Sascha Bischoff
2026-04-30 15:34 ` [PATCH 2/3] irqchip/gic-v5: Allow for nr_irqs > 1 for LPI alloc and teardown Sascha Bischoff
2026-05-05 20:08 ` Thomas Gleixner
2026-05-06 9:35 ` Sascha Bischoff
2026-04-30 15:34 ` [PATCH 3/3] irqchip/gic-v5: Allocate ITS parent LPIs as a range Sascha Bischoff
2026-05-02 10:40 ` [PATCH 0/3] irqchip/gic-v5: Tidy up LPI allocation Marc Zyngier
2026-05-04 8:45 ` Lorenzo Pieralisi
2026-05-05 9:03 ` Sascha Bischoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873405y68s.ffs@tglx \
--to=tglx@kernel.org \
--cc=Sascha.Bischoff@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.