Re: [PATCH v5 2/2] ui/gtk: Turn clipboard flag into runtime option

[Markus Armbruster <armbru@redhat.com>]

Jindřich Makovička <makovick@gmail.com> writes:

> - Compile the GTK clipboard support unconditionally
>
> - Introduce GTK clipboard option, defaulting to off

Should the patch be split?

> Signed-off-by: Jindrich Makovicka <makovick@gmail.com>

[...]

> diff --git a/qapi/ui.json b/qapi/ui.json
> index e3da77632a..b2c42a7f57 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -1319,6 +1319,9 @@
>  #
>  # GTK display options.
>  #
> +# @clipboard: Enable host-guest clipboard sharing.  Defaults to "off".
> +#     (Since 11.1)
> +#

Educate ignorant me: what does it mean to share the clipboard?

>  # @grab-on-hover: Grab keyboard input on mouse hover.
>  #
>  # @zoom-to-fit: Zoom guest display to fit into the host window.  When
> @@ -1344,7 +1347,8 @@
>  # Since: 2.12
>  ##
>  { 'struct'  : 'DisplayGTK',
> -  'data'    : { '*grab-on-hover'     : 'bool',
> +  'data'    : { '*clipboard'         : 'bool',
> +                '*grab-on-hover'     : 'bool',
>                  '*zoom-to-fit'       : 'bool',
>                  '*show-tabs'         : 'bool',
>                  '*show-menubar'      : 'bool',
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 21972f8326..e780bc2ac0 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2209,9 +2209,9 @@ DEF("display", HAS_ARG, QEMU_OPTION_display,
>      "            [,window-close=on|off]\n"
>  #endif
>  #if defined(CONFIG_GTK)
> -    "-display gtk[,full-screen=on|off][,gl=on|off][,grab-on-hover=on|off]\n"
> -    "            [,show-tabs=on|off][,show-cursor=on|off][,window-close=on|off]\n"
> -    "            [,show-menubar=on|off][,zoom-to-fit=on|off]\n"
> +    "-display gtk[,clipboard=on|off][,full-screen=on|off][,gl=on|off]\n"
> +    "            [,grab-on-hover=on|off][,show-tabs=on|off][,show-cursor=on|off]\n"
> +    "            [,window-close=on|off][,show-menubar=on|off][,zoom-to-fit=on|off]\n"
>  #endif
>  #if defined(CONFIG_VNC)
>      "-display vnc=<display>[,<optargs>]\n"
> @@ -2295,6 +2295,9 @@ SRST
>          drop-down menus and other UI elements to configure and control
>          the VM during runtime. Valid parameters are:
>  
> +        ``clipboard=on|off`` : Enable host-guest clipboard sharing,
> +                               defaults to "off"
> +
>          ``full-screen=on|off`` : Start in fullscreen mode
>  
>          ``gl=on|off`` : Use OpenGL for displaying

[...]