From: Markus Armbruster <armbru@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PATCH v1] checkpatch: Allow spaces after all coroutine annotations
Date: Tue, 21 Apr 2026 08:03:23 +0200 [thread overview]
Message-ID: <87340oalzo.fsf@pond.sub.org> (raw)
In-Reply-To: <20260420191356.4439-1-farosas@suse.de> (Fabiano Rosas's message of "Mon, 20 Apr 2026 16:13:56 -0300")
Fabiano Rosas <farosas@suse.de> writes:
> The coroutine annotations may be used in the declaration of function
> pointers, which triggers checkpatch due to the space before the
> parentheses. E.g:
>
> int coroutine_fn (*run)(Job *job, Error **errp);
> ^
> The coroutine_fn annotation is already included in the list of terms
> where spaces are allowed. Add the other coroutine annotations:
> coroutine_mixed_fn and no_coroutine_fn.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> the next migration PR will trigger this
> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index b77bd69328..e1cf2ff23b 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2441,6 +2441,7 @@ sub process {
> if ($name =~ /^(?:
> if|for|while|switch|return|case|
> volatile|__volatile__|coroutine_fn|
> + coroutine_mixed_fn|no_coroutine_fn|
> __attribute__|format|__extension__|
> asm|__asm__)$/x)
> {
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2026-04-21 6:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 19:13 [PATCH v1] checkpatch: Allow spaces after all coroutine annotations Fabiano Rosas
2026-04-21 6:03 ` Markus Armbruster [this message]
2026-04-23 8:29 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87340oalzo.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=farosas@suse.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.