Re: [PATCH] hw/ide: resolve core crash caused by optical drive pop-up during virtual machine startup

[Markus Armbruster <armbru@redhat.com>]

Reproducer?

Is this a regression?

yanlonglong <yanlonglong@kylinos.cn> writes:

> Signed-off-by: yanlonglong <yanlonglong@kylinos.cn>
> ---
>  hw/ide/atapi.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
> index a42b748521..d14feed45b 100644
> --- a/hw/ide/atapi.c
> +++ b/hw/ide/atapi.c
> @@ -153,6 +153,11 @@ static void cd_read_sector_cb(void *opaque, int ret)
>  static int cd_read_sector(IDEState *s)
>  {
>      void *buf;
> +    
> +    //resolve core crash caused by optical drive pop-up during virtual machine startup

docs/devel/style.rst:

    We use traditional C-style /``*`` ``*``/ comments and avoid // comments.

> +    if (!blk_is_available(s->blk)) {
> +        return -ENOMEDIUM;
> +    }
>  
>      if (s->cd_sector_size != 2048 && s->cd_sector_size != 2352) {
>          block_acct_invalid(blk_get_stats(s->blk), BLOCK_ACCT_READ);