From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: mst@redhat.com, sgarzare@redhat.com, qemu-devel@nongnu.org,
d-tatianin@yandex-team.ru, Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH 06/10] qapi: remove user addresses from x-query-virtio-vhost-queue-status
Date: Tue, 17 Feb 2026 16:27:03 +0100 [thread overview]
Message-ID: <87342zie60.fsf@pond.sub.org> (raw)
In-Reply-To: <86722929-9a4b-49d1-8e69-53f158b20e45@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Tue, 17 Feb 2026 15:08:47 +0300")
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
> On 17.02.26 12:03, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
>>
>>> Remove desc, avail, and used fields as they expose process address space
>>> information and violate ASLR.
>>
>> Isn't the user of the monitor trusted?
>
> I don't know exactly the policy here. If keep these fields, their semantics
> will change anyway with these series. So I decided, it's simpler to drop
> them (if no objections), keeping in mind experimental status of the command
> and ASLR.
The monitor lets you read arbitrary virtual and physical guest memory.
Feels trusted to me :)
"Violate ASLR" suggests security is at stake somehow. I doubt it is.
"will change anyway" and "it's simpler to drop them" makes me suspect
they're not useful enough to be worth their keep. If this is the actual
reason for dropping them, please rewrite your commit message to say so.
>>
>>> Since this is an experimental command, we
>>> can safely remove these potentially sensitive fields.
>>>
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
>>
>> Patch looks good.
next prev parent reply other threads:[~2026-02-17 15:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 7:38 [PATCH 00/10] vhost-user: VHOST_USER_PROTOCOL_F_GPA_ADDRESSES Vladimir Sementsov-Ogievskiy
2026-02-09 7:38 ` [PATCH 01/10] vhost: move IOTLB functions from vhost-backend.c to vhost.c Vladimir Sementsov-Ogievskiy
2026-02-09 7:38 ` [PATCH 02/10] vhost: use consistent naming for backend handlers Vladimir Sementsov-Ogievskiy
2026-02-09 7:39 ` [PATCH 03/10] vhost: rename vhost-backend.c to vhost-kernel.c Vladimir Sementsov-Ogievskiy
2026-02-09 7:39 ` [PATCH 04/10] vhost: replace .vhost_vq_get_addr() with .vhost_phys_vring_addr() Vladimir Sementsov-Ogievskiy
2026-02-09 7:39 ` [PATCH 05/10] vhost: simplify vhost_memory_map() and vhost_memory_unmap() Vladimir Sementsov-Ogievskiy
2026-02-09 7:39 ` [PATCH 06/10] qapi: remove user addresses from x-query-virtio-vhost-queue-status Vladimir Sementsov-Ogievskiy
2026-02-17 9:03 ` Markus Armbruster
2026-02-17 12:08 ` Vladimir Sementsov-Ogievskiy
2026-02-17 15:27 ` Markus Armbruster [this message]
2026-02-17 18:03 ` Vladimir Sementsov-Ogievskiy
2026-02-09 7:39 ` [PATCH 07/10] vhost: stop reusing vq->desc (and friends) to store physical address Vladimir Sementsov-Ogievskiy
2026-02-09 7:39 ` [PATCH 08/10] vhost: rename vring pointer fields to reflect user addresses Vladimir Sementsov-Ogievskiy
2026-02-09 7:39 ` [PATCH 09/10] vhost: add .vhost_phys_iotlb_msg() handler Vladimir Sementsov-Ogievskiy
2026-02-09 7:39 ` [PATCH 10/10] vhost-user: add VHOST_USER_PROTOCOL_F_GPA_ADDRESSES Vladimir Sementsov-Ogievskiy
2026-02-09 7:45 ` [PATCH 00/10] vhost-user: VHOST_USER_PROTOCOL_F_GPA_ADDRESSES Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87342zie60.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=d-tatianin@yandex-team.ru \
--cc=eblake@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.