From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65FE3E95375 for ; Wed, 4 Feb 2026 10:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oz2a9ZekMaVV37fV9v8uqglBnvv8U6ltO/BY9X+MYNs=; b=oSFiKbQZdd+skA l8mJByXGgcLx4q573bQ4jMsul3T9hJ+q0Dri4m4KfHp1gF62e09aws/w0iO2o+N5MPR4wuA99Zz72 7AuWkmcM+WcqwCwBJ3t7QWxoJhtfqQJxi+36jNsMeArYixwpWoJw1uCK5QGryKdH1l1Pg/4LM4OZd D7msRJ4zsSllQ1JlmTX7S4gqmwojebaQRDxxV1/ZfKRbddcCkliH975ZXxJWICaVHMvIvxklRf0qe QQDTUcErhcET8OuwtgZOWYnE+CJroS/l2s1a/8ZblTc47Uv3YDrvma5Onbpdz4n3O25xavcPIm3ca LXqtCAkLy/+dxKD+GEIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vna8N-00000008HsX-1qsO; Wed, 04 Feb 2026 10:29:19 +0000 Received: from smtpout-03.galae.net ([185.246.85.4]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vna8K-00000008HsD-1jx6 for linux-mtd@lists.infradead.org; Wed, 04 Feb 2026 10:29:18 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 75AAE4E423F3; Wed, 4 Feb 2026 10:29:13 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 46B1B60745; Wed, 4 Feb 2026 10:29:13 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 136BF119A865B; Wed, 4 Feb 2026 11:29:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770200952; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=01QzhpC+ZgIOpSS8o+hjNlELWio1HwrhuHHzfZRg1Sk=; b=oaqQ7l765iQGfSSBX//MES/7TjJpX1/lKC0GyoQDpXOQCn65sDKixQW1izvZx0JghaJrOR w45VURFbK+s0tQgpoqr7mbYdRn0x5WCWZyM//0viVoBMTSS4gCKawU3MKv5Osd/aFc+5VO 8/c2T/N35yj8P/tpq+LNDCg4fXIJ8XD6iqV6uACasvhqgE6pi/WuDwqkor2klF3/FzMhf1 pBhHOnGlp7ruQd7rI0sHSzEdPo1+W9EiYGx/WvBDlrChXYT3E1wEQTQD/ZiANCYS9+xEQm C3tL1rmp2UyPyAjsjDHiKzWhq7Ek+UCm/NwDP/t62jGxMEFqIFeaR9eZUUqaOg== From: Miquel Raynal To: Santhosh Kumar K Cc: , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v2 00/12] spi: cadence-quadspi: add PHY tuning support In-Reply-To: <20260113141617.1905039-1-s-k6@ti.com> (Santhosh Kumar K.'s message of "Tue, 13 Jan 2026 19:46:05 +0530") References: <20260113141617.1905039-1-s-k6@ti.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Wed, 04 Feb 2026 11:29:07 +0100 Message-ID: <87343ghkek.fsf@bootlin.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260204_022916_718304_E63E1BF7 X-CRM114-Status: GOOD ( 16.39 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgU2FudGhvc2gsCgpPbiAxMy8wMS8yMDI2IGF0IDE5OjQ2OjA1ICswNTMwLCBTYW50aG9zaCBL dW1hciBLIDxzLWs2QHRpLmNvbT4gd3JvdGU6Cgo+IFRoaXMgc2VyaWVzIGltcGxlbWVudHMgUEhZ IHR1bmluZyBzdXBwb3J0IGZvciB0aGUgQ2FkZW5jZSBRU1BJIGNvbnRyb2xsZXIgdG8KPiBlbmFi bGUgcmVsaWFibGUgaGlnaC1zcGVlZCBvcGVyYXRpb25zLiBXaXRob3V0IFBIWSB0dW5pbmcsIGNv bnRyb2xsZXJzIHVzZQo+IGNvbnNlcnZhdGl2ZSB0aW1pbmcgdGhhdCBsaW1pdHMgdGhlIHBlcmZv cm1hbmNlLiBQSFkgdHVuaW5nIGNhbGlicmF0ZXMgUlgvVFgKPiBkZWxheSBsaW5lcyB0byBmaW5k IG9wdGltYWwgZGF0YSBjYXB0dXJlIHRpbWluZyB3aW5kb3dzLCBlbmFibGluZyBvcGVyYXRpb24g dXAKPiB0byB0aGUgY29udHJvbGxlcidzIG1heGltdW0gZnJlcXVlbmN5Lgo+Cj4gQmFja2dyb3Vu ZDoKPiBIaWdoLXNwZWVkIFNQSSBtZW1vcnkgY29udHJvbGxlcnMgcmVxdWlyZSBwcmVjaXNlIHRp bWluZyBjYWxpYnJhdGlvbiBmb3IKPiByZWxpYWJsZSBvcGVyYXRpb24uIEF0IGhpZ2hlciBmcmVx dWVuY2llcywgYm9hcmQtdG8tYm9hcmQgdmFyaWF0aW9ucyBtYWtlCj4gZml4ZWQgdGltaW5nIHBh cmFtZXRlcnMgaW5hZGVxdWF0ZS4gVGhlIENhZGVuY2UgUVNQSSBjb250cm9sbGVyIGluY2x1ZGVz Cj4gYSBQSFkgaW50ZXJmYWNlIHdpdGggcHJvZ3JhbW1hYmxlIGRlbGF5IGxpbmVzICgwLTEyNyB0 YXBzKSBmb3IgUlggYW5kIFRYCj4gcGF0aHMsIGJ1dCB0aGVzZSByZXF1aXJlIHJ1bnRpbWUgY2Fs aWJyYXRpb24gdG8gZmluZCB0aGUgdmFsaWQgdGltaW5nIHdpbmRvdy4KPgo+IEFwcHJvYWNoOgo+ IEFkZCBTRFIvRERSIFBIWSB0dW5pbmcgYWxnb3JpdGhtcyBmb3IgdGhlIENhZGVuY2UgY29udHJv bGxlcjoKPgo+IFNEUiBNb2RlIFR1bmluZyAoMUQgc2VhcmNoKToKPiAtIFNlYXJjaGVzIGZvciB0 d28gY29uc2VjdXRpdmUgdmFsaWQgUlggZGVsYXkgd2luZG93cwo+IC0gU2VsZWN0cyB0aGUgbGFy Z2VyIHdpbmRvdyBhbmQgdXNlcyBpdHMgbWlkcG9pbnQgZm9yIG1heGltdW0gbWFyZ2luCj4gLSBU WCBkZWxheSBmaXhlZCBhdCBtYXhpbXVtICgxMjcpIGFzIGl0J3MgbGVzcyBjcml0aWNhbCBpbiBT RFIKPgo+IEREUiBNb2RlIFR1bmluZyAoMkQgc2VhcmNoKToKPiAtIEZpbmRzIFJYIGJvdW5kYXJp ZXMgKHJ4bG93L3J4aGlnaCkgdXNpbmcgVFggd2luZG93IHN3ZWVwcwo+IC0gRmluZHMgVFggYm91 bmRhcmllcyAodHhsb3cvdHhoaWdoKSBhdCBmaXhlZCBSWCBwb3NpdGlvbnMKPiAtIERlZmluZXMg dmFsaWQgcmVnaW9uIGNvcm5lcnMgYW5kIGRldGVjdHMgZ2FwcyB2aWEgYmluYXJ5IHNlYXJjaAo+ IC0gQXBwbGllcyB0ZW1wZXJhdHVyZSBjb21wZW5zYXRpb24gZm9yIG9wdGltYWwgcG9pbnQgc2Vs ZWN0aW9uCj4gLSBIYW5kbGVzIHNpbmdsZSBvciBkdWFsIHBhc3NpbmcgcmVnaW9ucyB3aXRoIGRp ZmZlcmVudCBzdHJhdGVnaWVzCj4KPiBEUVMgU3VwcG9ydDoKPiAtIEFkZHMgb3B0aW9uYWwgRFFT IChEYXRhIFN0cm9iZSkgbW9kZSBmb3IgaW1wcm92ZWQgdGltaW5nIG1hcmdpbnMKPiAtIENvbmZp Z3VyZXMgcmVhZCBkYXRhIGNhcHR1cmUgdG8gdXNlIGRlZGljYXRlZCBzdHJvYmUgc2lnbmFsCgpJ IGFtIGdsYWQgdG8ga25vdyB0aGlzIHNpZ25hbCBpcyB1c2VmdWwuIEkgZG8gbm90IGNvbnNpZGVy IHRoZSBEVApwcm9wZXJ0eSBhcyBiZWluZyB0aGUgY29ycmVjdCB3YXkgdG8gY2FycnkgdGhpcyBp bmZvcm1hdGlvbiBBVE0sIHNvIEkKd2lsbCBpbnZlc3RpZ2F0ZSBhIGJpdCBhIHByb3Bvc2UgYSBz b2x1dGlvbiB0aGF0IGlzIG1vcmUgdW5pZm9ybSB3aXRoCnRoZSByZXN0IG9mIHRoZSBjaGlwcyBk ZXNjcmlwdGlvbiB3ZSBoYXZlIHRvZGF5LgoKPiBQYXRjaCBkZXNjcmlwdGlvbjoKPiBJbmZyYXN0 cnVjdHVyZSAoMS01KToKPiAtIFBhdGNoIDE6ICAgQWRkIERUIGJpbmRpbmcgZm9yIHNwaS1oYXMt ZHFzIHByb3BlcnR5Cj4gLSBQYXRjaCAyOiAgIEltcGxlbWVudCBzcGlfbWVtX2V4ZWN1dGVfdHVu aW5nKCkgQVBJIGluIFNQSSBjb3JlCj4gLSBQYXRjaCAzLTU6IFJlZmFjdG9yIGFuZCBpbnRlZ3Jh dGUgdHVuaW5nIGluIE1URCBTUEktTkFORC9OT1IgbGF5ZXJzIGFuZCBjYWxsCj4gICAgICAgICAg ICAgIHR1bmluZyBkdXJpbmcgcHJvYmUKPgo+IENhZGVuY2UgUVNQSSBJbXBsZW1lbnRhdGlvbiAo Ni0xMik6Cj4gLSBQYXRjaCA2LTg6IFByZXBhcmF0b3J5IHJlZmFjdG9yaW5nIGFuZCBEUVMgc3Vw cG9ydAo+IC0gUGF0Y2ggOTogICBBZGQgUEhZIHR1bmluZyBpbmZyYXN0cnVjdHVyZSB3aXRoIHBs YWNlaG9sZGVycwo+IC0gUGF0Y2ggMTA6ICBJbXBsZW1lbnQgY29tcGxldGUgU0RSL0REUiB0dW5p bmcgYWxnb3JpdGhtcwo+IC0gUGF0Y2ggMTE6ICBSZXN0cmljdCBQSFkgZnJlcXVlbmN5IHRvIGNh bGlicmF0ZWQgb3BlcmF0aW9ucyBvbmx5Cj4gLSBQYXRjaCAxMjogIEVuYWJsZSBQSFkgZm9yIGRp cmVjdCBtZW1vcnktbWFwcGVkIHJlYWRzIGFuZCBsYXJnZSB3cml0ZXMKPgo+IFRlc3Rpbmc6Cj4g VGhpcyBzZXJpZXMgd2FzIHRlc3RlZCBvbiBUSSdzCj4gQU02MkEgU0sgd2l0aCBPU1BJIE5BTkQg Zmxhc2ggYW5kCj4gQU02MlAgU0sgd2l0aCBPU1BJIE5PUiBmbGFzaDoKPgo+IFJlYWQgdGhyb3Vn aHB1dDoKPiB8LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLXwKPiB8ICAgICAg ICAgICB8IHdpdGhvdXQgUEhZIHwgd2l0aCBQSFkgIHwKPiB8LS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLXwgICAgICAgICAgIAo+IHxPU1BJIE5PUiAgIHwgMzcuNSBNQi9zICAg fCAyMTYgTUIvcyAgfAo+IHwtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tfAo+ IHxPU1BJIE5BTkQgIHwgOS4yIE1CL3MgICAgfCAzNS4xIE1CL3MgfAo+IHwtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tfAoKSSBhbSBzdXJwcmlzZWQgYnkgdGhlc2UgbnVtYmVy cywgSSB3b3VsZCBleHBlY3QgdGhlc2UgdG8gZ2V0IGhpZ2hlciBmb3IKU1BJIE5BTkRzLiBJIHdp bGwgdGVzdCB0aGUgc2VyaWVzIGFuZCByZXBvcnQgbXkgb2JzZXJ2YXRpb25zLCBlc3BlY2lhbGx5 CnNpbmNlIHRoZXJlIGlzIGFsc28gT0REUiBTUEkgTkFORCBzdXBwb3J0IG5vdyAoaW4gbmFuZC9u ZXh0LCBzaG91bGQgYmUKcGFydCBvZiBteSB1cGNvbWluZyBtZXJnZSByZXF1ZXN0IHRvIExpbnVz IGZvciA2LjE5KzEpOwoKPiBXcml0ZSB0aHJvdWdocHV0Ogo+IHwtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tfAo+IHwgICAgICAgICAgIHwgd2l0aG91dCBQSFkgfCB3aXRoIFBI WSAgfAo+IHwtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tfCAgICAgICAgICAg Cj4gfE9TUEkgTkFORCAgfCA2IE1CL3MgICAgICB8IDkuMiBNQi9zICB8Cj4gfC0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS18CgpPdmVyYWxsIEkgd2FudCB0byBzYXkgdGhhdCB0 aGlzIHNlcmllcyBoYXMgZ3JlYXRseSBpbXByb3ZlZCBhbHJlYWR5LCBJCmFtIHJlYWxseSBsb29r aW5nIGZvcndhcmQgc2VlaW5nIHRoaXMgbWVyZ2VkLiBJIGhhdmUgc2V2ZXJhbCBjb21tZW50cyB0 bwptYWtlLCBidXQgdGhleSBhcmUgbW9zdGx5IG1pbm9yIGltcHJvdmVtZW50cyB3aGljaCB3b24n dCBiZSB2ZXJ5CmltcGFjdGluZy4KClRoZSB0dW5pbmcgcHJvY2VkdXJlIGlzIHZlcnkgd2VsbCBk ZXNjcmliZWQgaW4gdGhlIGNvZGUgYXMgd2VsbCwgd2hpY2gKaXMgYXBwcmVjaWF0ZWQuCgpQbGVh c2UgcmVtb3ZlIHRoZSBSRkMgcHJlZml4IGZvciB2MywgaXQgaXMgY2xlYXJseSBubyBsb25nZXIg bmVlZGVkLgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0 Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74FBC3D7D94; Wed, 4 Feb 2026 10:29:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770200955; cv=none; b=dNKn8/VvaSk28QgZisJdVifwcRRCQHKCPSVnORhpuin9u5okeS9mFnsFyVDK7pOJrRNBqHfNcUlT63x7MFqF1Q4jxWQfwOHnTrBuwQk9+ylRCRnjS9BtncAq6mOYAgaA6LXjodXXKwpuTPjjEbZqag0opTdyhx2Y0G5Tm4zYOhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770200955; c=relaxed/simple; bh=LB2WMksQyfGJhpuEI5Ie02v21FjdlyP1rys2s1FlD/0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=usw/nP3B1XtmdjwiS24fwIJaFCl1K3rfRGSEB1sQg5Vzk9chTGzjpSBSb20T/Yw+XdfoANwDdFKtmo3wguTs7hvjjf1a/iauMQRnjwwxSDKbYI/0PK/T/IeSBYX+62WpQCTSgFtEboQvhCUUtv7M9HfKG9xJTNbFENYpIVNzQF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=oaqQ7l76; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="oaqQ7l76" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id DD18DC24394; Wed, 4 Feb 2026 10:29:18 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 46B1B60745; Wed, 4 Feb 2026 10:29:13 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 136BF119A865B; Wed, 4 Feb 2026 11:29:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770200952; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=01QzhpC+ZgIOpSS8o+hjNlELWio1HwrhuHHzfZRg1Sk=; b=oaqQ7l765iQGfSSBX//MES/7TjJpX1/lKC0GyoQDpXOQCn65sDKixQW1izvZx0JghaJrOR w45VURFbK+s0tQgpoqr7mbYdRn0x5WCWZyM//0viVoBMTSS4gCKawU3MKv5Osd/aFc+5VO 8/c2T/N35yj8P/tpq+LNDCg4fXIJ8XD6iqV6uACasvhqgE6pi/WuDwqkor2klF3/FzMhf1 pBhHOnGlp7ruQd7rI0sHSzEdPo1+W9EiYGx/WvBDlrChXYT3E1wEQTQD/ZiANCYS9+xEQm C3tL1rmp2UyPyAjsjDHiKzWhq7Ek+UCm/NwDP/t62jGxMEFqIFeaR9eZUUqaOg== From: Miquel Raynal To: Santhosh Kumar K Cc: , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v2 00/12] spi: cadence-quadspi: add PHY tuning support In-Reply-To: <20260113141617.1905039-1-s-k6@ti.com> (Santhosh Kumar K.'s message of "Tue, 13 Jan 2026 19:46:05 +0530") References: <20260113141617.1905039-1-s-k6@ti.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Wed, 04 Feb 2026 11:29:07 +0100 Message-ID: <87343ghkek.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Santhosh, On 13/01/2026 at 19:46:05 +0530, Santhosh Kumar K wrote: > This series implements PHY tuning support for the Cadence QSPI controller= to > enable reliable high-speed operations. Without PHY tuning, controllers use > conservative timing that limits the performance. PHY tuning calibrates RX= /TX > delay lines to find optimal data capture timing windows, enabling operati= on up > to the controller's maximum frequency. > > Background: > High-speed SPI memory controllers require precise timing calibration for > reliable operation. At higher frequencies, board-to-board variations make > fixed timing parameters inadequate. The Cadence QSPI controller includes > a PHY interface with programmable delay lines (0-127 taps) for RX and TX > paths, but these require runtime calibration to find the valid timing win= dow. > > Approach: > Add SDR/DDR PHY tuning algorithms for the Cadence controller: > > SDR Mode Tuning (1D search): > - Searches for two consecutive valid RX delay windows > - Selects the larger window and uses its midpoint for maximum margin > - TX delay fixed at maximum (127) as it's less critical in SDR > > DDR Mode Tuning (2D search): > - Finds RX boundaries (rxlow/rxhigh) using TX window sweeps > - Finds TX boundaries (txlow/txhigh) at fixed RX positions > - Defines valid region corners and detects gaps via binary search > - Applies temperature compensation for optimal point selection > - Handles single or dual passing regions with different strategies > > DQS Support: > - Adds optional DQS (Data Strobe) mode for improved timing margins > - Configures read data capture to use dedicated strobe signal I am glad to know this signal is useful. I do not consider the DT property as being the correct way to carry this information ATM, so I will investigate a bit a propose a solution that is more uniform with the rest of the chips description we have today. > Patch description: > Infrastructure (1-5): > - Patch 1: Add DT binding for spi-has-dqs property > - Patch 2: Implement spi_mem_execute_tuning() API in SPI core > - Patch 3-5: Refactor and integrate tuning in MTD SPI-NAND/NOR layers and= call > tuning during probe > > Cadence QSPI Implementation (6-12): > - Patch 6-8: Preparatory refactoring and DQS support > - Patch 9: Add PHY tuning infrastructure with placeholders > - Patch 10: Implement complete SDR/DDR tuning algorithms > - Patch 11: Restrict PHY frequency to calibrated operations only > - Patch 12: Enable PHY for direct memory-mapped reads and large writes > > Testing: > This series was tested on TI's > AM62A SK with OSPI NAND flash and > AM62P SK with OSPI NOR flash: > > Read throughput: > |-------------------------------------| > | | without PHY | with PHY | > |-------------------------------------|=20=20=20=20=20=20=20=20=20=20=20 > |OSPI NOR | 37.5 MB/s | 216 MB/s | > |-------------------------------------| > |OSPI NAND | 9.2 MB/s | 35.1 MB/s | > |-------------------------------------| I am surprised by these numbers, I would expect these to get higher for SPI NANDs. I will test the series and report my observations, especially since there is also ODDR SPI NAND support now (in nand/next, should be part of my upcoming merge request to Linus for 6.19+1); > Write throughput: > |-------------------------------------| > | | without PHY | with PHY | > |-------------------------------------|=20=20=20=20=20=20=20=20=20=20=20 > |OSPI NAND | 6 MB/s | 9.2 MB/s | > |-------------------------------------| Overall I want to say that this series has greatly improved already, I am really looking forward seeing this merged. I have several comments to make, but they are mostly minor improvements which won't be very impacting. The tuning procedure is very well described in the code as well, which is appreciated. Please remove the RFC prefix for v3, it is clearly no longer needed. Thanks, Miqu=C3=A8l