Re: [PATCH 2/2] drivers: irqchip: irq-ti-sci-intr: Allow parsing interrupt-types per-line

[Thomas Gleixner <tglx@kernel.org>]

On Fri, Jan 16 2026 at 18:38, Aniket Limaye wrote:

The subject line prefix is made up. Please follow the documented
conventions:

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-submission-notes

> Some INTR router instances act as simple passthroughs that preserve the
> source interrupt type unchanged at the output line, rather than converting
> all interrupts to a fixed type.
>
> When interrupt sources are not homogeneous with respect to trigger type,
> the driver needs to read each source's interrupt type from DT and pass it
> unchanged to its interrupt parent
>
> Previously, the interrupt type for all output lines was set globally using
> the "ti,intr-trigger-type" property (values 1 or 4).

What means 'previously'?

You want to describe the current state and not something which might be
in the past after applying the change.

> Add support for "ti,intr-trigger-type" = 15 (IRQ_TYPE_DEFAULT) to indicate
> passthrough mode:
> - When set to 15: Parse interrupt type per-line from DT
> - When set to 1 or 4: Use global setting (maintains backward compatibility)

> @@ -156,11 +168,27 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain,
>  		fwspec.param_count = 3;
>  		fwspec.param[0] = 0;	/* SPI */
>  		fwspec.param[1] = p_hwirq - 32; /* SPI offset */
> -		fwspec.param[2] = intr->type;
> +		fwspec.param[2] = hwirq_type;
>  	} else {
>  		/* Parent is Interrupt Router */
> -		fwspec.param_count = 1;
> -		fwspec.param[0] = p_hwirq;
> +		u32 parent_trigger_type;
> +
> +		err = of_property_read_u32(parent_node,
> +					  "ti,intr-trigger-type",
> +					  &parent_trigger_type);

You have 100 characters and if you need a line break align the second
line argument with the first line argument and not with the bracket.
See documentation.

> +		if (err)
> +			goto err_irqs;
> +
> +		if (parent_trigger_type != IRQ_TYPE_DEFAULT) {
> +			/* Parent has global trigger type */
> +			fwspec.param_count = 1;
> +			fwspec.param[0] = p_hwirq;
> +		} else {
> +			/* Parent supports per-line trigger types */
> +			fwspec.param_count = 2;
> +			fwspec.param[0] = p_hwirq;
> +			fwspec.param[1] = hwirq_type;
> +		}
>  	}
>  
>  	err = irq_domain_alloc_irqs_parent(domain, virq, 1, &fwspec);
> @@ -197,14 +225,14 @@ static int ti_sci_intr_irq_domain_alloc(struct irq_domain *domain,
>  {
>  	struct irq_fwspec *fwspec = data;
>  	unsigned long hwirq;
> -	unsigned int flags;
> +	unsigned int hwirq_type;

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#variable-declarations

>  	int err, out_irq;
>  
> -	err = ti_sci_intr_irq_domain_translate(domain, fwspec, &hwirq, &flags);
> +	err = ti_sci_intr_irq_domain_translate(domain, fwspec, &hwirq, &hwirq_type);
>  	if (err)
>  		return err;
>  
> -	out_irq = ti_sci_intr_alloc_parent_irq(domain, virq, hwirq);
> +	out_irq = ti_sci_intr_alloc_parent_irq(domain, virq, hwirq, hwirq_type);
>  	if (out_irq < 0)
>  		return out_irq;

Thanks,

        tglx