All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: checkpatch.pl warning on "added, moved or deleted" messed up
Date: Fri, 09 Jan 2026 08:13:25 +0100	[thread overview]
Message-ID: <87344fntre.fsf@pond.sub.org> (raw)
In-Reply-To: <aV_CZYA3KokrT4xh@redhat.com> ("Daniel P. Berrangé"'s message of "Thu, 8 Jan 2026 14:42:45 +0000")

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Thu, Jan 08, 2026 at 01:57:56PM +0100, Markus Armbruster wrote:
>> I ran checkpatch on my
>> 
>>     [PATCH 0/2] migration: Drop deprecated QMP stuff
>>     Message-ID: <20260108125512.2234147-1-armbru@redhat.com>
>> 
>> and got
>> 
>>     $ scripts/checkpatch.pl --terse *patch
>>     0001-migration-Drop-deprecated-QMP-command-query-migratio.patch:290: WARNING: added, moved or deleted file(s):
>>     total: 0 errors, 1 warnings, 129 lines checked
>> 
>> The culprit seems to be commit 1d745e6d963 (scripts/checkpatch: use new
>> hook for MAINTAINERS update check).  If I use the version immediately
>> preceding it, I get:
>> 
>>     0001-migration-Drop-deprecated-QMP-command-query-migratio.patch:105: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
>>     total: 0 errors, 1 warnings, 129 lines checked
>
> Hmm, the problem is the --terse command is rather crude and simply
> throws away everything except the first line of text. My commit made
> the verbose output multi-line to improve readability
>
> $ ./scripts/checkpatch.pl  ~/dep
> WARNING: added, moved or deleted file(s):
>
>   migration/threadinfo.h
>   migration/threadinfo.c
>
> Does MAINTAINERS need updating?
>
> total: 0 errors, 1 warnings, 193 lines checked
>
> /var/home/berrange/dep has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
>
> but this inadvertantly made terse output worse :-(

Aha!

I posted a patch, Message-ID: <20260109071217.2326194-1-armbru@redhat.com>

Thanks!



      reply	other threads:[~2026-01-09  7:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08 12:57 checkpatch.pl warning on "added, moved or deleted" messed up Markus Armbruster
2026-01-08 14:42 ` Daniel P. Berrangé
2026-01-09  7:13   ` Markus Armbruster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87344fntre.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.