From: Thomas Gleixner <tglx@linutronix.de>
To: Charles Mirabile <cmirabil@redhat.com>, lkp@intel.com
Cc: cmirabil@redhat.com, linux-kernel@vger.kernel.org,
lzampier@redhat.com, oe-kbuild-all@lists.linux.dev,
x86@kernel.org
Subject: Re: [tip:irq/drivers 22/22] drivers/irqchip/irq-sifive-plic.c:590:55: sparse: sparse: incorrect type in argument 1 (different address spaces)
Date: Fri, 31 Oct 2025 22:32:52 +0100 [thread overview]
Message-ID: <87346ysqnv.ffs@tglx> (raw)
In-Reply-To: <20251027174725.1014197-1-cmirabil@redhat.com>
On Mon, Oct 27 2025 at 13:47, Charles Mirabile wrote:
> diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
> index 9c4af7d58846..fbf7378899d3 100644
> --- a/drivers/irqchip/irq-sifive-plic.c
> +++ b/drivers/irqchip/irq-sifive-plic.c
> @@ -590,12 +590,12 @@ static int plic_probe(struct fwnode_handle *fwnode)
> if (parent_hwirq != RV_IRQ_EXT) {
> /* Disable S-mode enable bits if running in M-mode. */
> if (IS_ENABLED(CONFIG_RISCV_M_MODE)) {
> - void __iomem *enable_base = priv->regs +
> + u32 __iomem *enable_base = priv->regs +
> CONTEXT_ENABLE_BASE +
> i * CONTEXT_ENABLE_SIZE;
>
> - for (hwirq = 1; hwirq <= nr_irqs; hwirq++)
> - __plic_toggle(enable_base, hwirq, 0);
> + for (int j = 0; j <= nr_irqs / 32; j++)
> + writel(0, enable_base + j);
> }
> continue;
> }
Care to send a proper patch for that?
prev parent reply other threads:[~2025-10-31 21:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 5:16 [tip:irq/drivers 22/22] drivers/irqchip/irq-sifive-plic.c:590:55: sparse: sparse: incorrect type in argument 1 (different address spaces) kernel test robot
2025-10-27 17:47 ` Charles Mirabile
2025-10-31 21:32 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87346ysqnv.ffs@tglx \
--to=tglx@linutronix.de \
--cc=cmirabil@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lzampier@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.