Re: [PATCH] tests/intel/xe_exec_reset: expect error or complete on CAT_ERROR

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 19 Sep 2025 17:07:28 -0700, Daniel Charles wrote:
>
> On 9/19/2025 4:59 PM, Dixit, Ashutosh wrote:
> > On Fri, 19 Sep 2025 15:28:36 -0700, Daniel Charles wrote:
> >> when running cm job, it could be that after the fence is checked, a
> >> CAT_ERROR will throw an error in the same way as GT_RESET does.
> >>
> >> Signed-off-by: Daniel Charles <daniel.charles@intel.com>
> >> ---
> >>   tests/intel/xe_exec_reset.c | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
> >> index 7ae53c679..73c5c7e20 100644
> >> --- a/tests/intel/xe_exec_reset.c
> >> +++ b/tests/intel/xe_exec_reset.c
> >> @@ -433,7 +433,7 @@ test_compute_mode(int fd, struct drm_xe_engine_class_instance *eci,
> >>
> >>		err = __xe_wait_ufence(fd, &data[i].exec_sync, USER_FENCE_VALUE,
> >>				       exec_queues[i % n_exec_queues], &timeout);
> >> -		if (flags & GT_RESET)
> >> +		if (flags & GT_RESET || flags & CAT_ERROR)
> > Hi Daniel,
> >
> > 1. Is there a gitlab bug about this? If yes, could you please add a
> >     'Closes:' tag to this patch (see git log)
> not that I'm aware of.

There should have been a previous failure which this patch is fixing,
correct? So we would expect there to be a previous bug. Anyway.

> >
> > 2. Would you have a reference to the kernel code that a CAT error returns
> >     -EIO?
>
> when there's an engine reset a job that was sent to execution and didn't
> finish before the cat error, the driver will return -EIO as it does with a
> full reset.

OK, from xe_guc_exec_queue_memory_cat_error_handler(), what happens is the
exec_queue is reset on CAT error, which in turn would return -EIO.

So this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>


>
> > Thanks.
> > --
> > Ashutosh
> >
> >>			/* exec races with reset: may return -EIO or complete */
> >>			igt_assert(err == -EIO || !err);
> >>		else
> >> --
> >> 2.43.0
> >>