All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org,  Christian Stewart <christian@aperture.us>
Subject: Re: [Buildroot] [PATCH] package/mbpfan: fix build on musl / uclibc-ng
Date: Mon, 01 Sep 2025 12:35:30 +0200	[thread overview]
Message-ID: <873496fojx.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20250829235308.18037377@windsurf> (Thomas Petazzoni's message of "Fri, 29 Aug 2025 23:53:08 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Fri, 29 Aug 2025 18:52:38 +0200
 > Peter Korsgaard <peter@korsgaard.com> wrote:

 >> define MBPFAN_BUILD_CMDS
 >> -	$(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS)" \
 >> +	$(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS) -D_DEFAULT_SOURCE" \

 > Upstream seems to still be active, so what about doing the "right"
 > thing, which is adding #define _DEFAULT_SOURCE in the source file, and
 > submitting an upstream patch?

I did that:

https://github.com/linux-on-mac/mbpfan/pull/271

And committed this patch after updating it to use the patch.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2025-09-01 10:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-29 16:52 [Buildroot] [PATCH] package/mbpfan: fix build on musl / uclibc-ng Peter Korsgaard
2025-08-29 21:53 ` Thomas Petazzoni via buildroot
2025-08-30  7:44   ` Peter Korsgaard
2025-09-01 10:35   ` Peter Korsgaard [this message]
2025-09-11 19:21 ` Thomas Perale via buildroot
2025-09-11 21:45   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873496fojx.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=christian@aperture.us \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.