From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE674C71136 for ; Mon, 16 Jun 2025 09:52:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 17B1E8210D; Mon, 16 Jun 2025 11:52:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="j4YYXSEU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 305B682AFD; Mon, 16 Jun 2025 11:52:46 +0200 (CEST) Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D4EF980C93 for ; Mon, 16 Jun 2025 11:52:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id DD7C0A51732; Mon, 16 Jun 2025 09:52:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09053C4CEEA; Mon, 16 Jun 2025 09:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750067562; bh=za1CFGANScdX6uTSuzAUuMDJiKAdaQ+zJq5MMqrXOxE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=j4YYXSEUHimVlz4kQ++zqFrUyhTcivYXn4jLGMdOawJLqHUoWeoFifS12n1Tpl9nM cf5WO7mHGROgKY7/RRbZ54i9nuntkj8vz2etrp84h3XHBOejDPQdMm5bz00TZo1MuH rx5pn9oKIuAYzc1sL52ySCyAyNqVNYv6ZpKqDsB3bPQr1wu0SFtVJ8I/KHm+A3Ca94 HMvv6ndyZvalBC8PrIJ8kzEDxpCbv3zrynV5J22/iqrzp/6PswxfGLN4fbCaYp451V IU/sczuz3fIZQ5DBeHTjdLLODrKYRQJT+kbiOWMU6Fn30hB5QuQM41ad5PnbhXvAOL Z4sJ4XoRzlEVQ== From: Mattijs Korpershoek To: Zixun LI , Mattijs Korpershoek Cc: Eugen Hristev , Lukasz Majewski , Marek Vasut , Tom Rini , Mihai Sain , u-boot@lists.denx.de Subject: Re: [PATCH] usb: gadget: atmel: reliably generate disconnect by disabling controller instead of toggling PULLD_DIS In-Reply-To: References: <20250602-pullup-v1-1-edcde5a050dd@hifiphile.com> <87iklbuddu.fsf@kernel.org> <87tt4k3sit.fsf@kernel.org> <878qlsgncu.fsf@kernel.org> <875xgwgn77.fsf@kernel.org> Date: Mon, 16 Jun 2025 11:52:39 +0200 Message-ID: <8734c0ggig.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Mon, Jun 16, 2025 at 10:45, Zixun LI wrote: > On Mon, Jun 16, 2025 at 9:28=E2=80=AFAM Mattijs Korpershoek > wrote: >> >> On Mon, Jun 16, 2025 at 09:24, Mattijs Korpershoek wrote: >> >> > On Fri, Jun 13, 2025 at 16:45, Zixun LI wrote: >> > >> >> On Fri, Jun 13, 2025 at 11:22=E2=80=AFAM Mattijs Korpershoek >> >> >> >> Hi Mattijs, >> >> >> >> The case was reported in early May and MCHP have also observed the >> >> missing of detach event on host. >> >> >> >> My latest measure shows a differential signal level about +-350mV >> >> between DP&DM lines when >> >> DETACH and PULLD_DIS bits are 1, much lower than the detachment >> >> threshold of 625mV from >> >> USB 2.0 specification Table 7.3. >> >> >> >> From my view the patch can be picked, even on an unaffected family it >> >> won't have side effects. >> >> Unless one day we decide to implement SAM9RL and SAM9G45 errata then >> >> it needs to be retested. >> > >> > Ok, I will apply it. Since it's a bit late in the release cycle, I'll >> > send this out for -next. >> >> Zixun, before applying the patch, I'd like to add the comment I >> suggested in the code [1] as well. >> >> Do you you have any objections on that? >> PLease let me know >> >> [1] https://lore.kernel.org/all/87iklbuddu.fsf@kernel.org/ >> >> > >> > Thanks again for your contribution! >> > >> > Mattijs >> > >> >> >> >> Best Regards, >> >> Zixun > > Hi Mattijs, > > I agree to add the comment to make it more clear. Great, thanks, I'll apply and do the fixup. > > Best regards, > Zixun