From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D940C5AE59 for ; Tue, 3 Jun 2025 16:09:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMUCP-0008Cu-Hg; Tue, 03 Jun 2025 12:09:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMUCJ-00084b-UG for qemu-devel@nongnu.org; Tue, 03 Jun 2025 12:09:08 -0400 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMUCE-0004Kh-Ga for qemu-devel@nongnu.org; Tue, 03 Jun 2025 12:09:07 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A065821216; Tue, 3 Jun 2025 16:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1748966938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gH0fPMGyXogjgY8zr8pXISyR55z2UtY+wSyw7iaZ3aY=; b=Y7/b/PGho6VDdsJDXrYmgwQzE0/DSWgapCpwxbc/4KBH2mAk7DmGJQraHNqxoEvRVofzQ5 ZO5/B1riz9mlnVOcfCHJEtHcfVsPwrqNQTgq0yFJeqzb4jpiXgC9pL1S//HEuRy36tTT2g keqqwAcMDzlo/kCiv7W2hylflM8NKW8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1748966938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gH0fPMGyXogjgY8zr8pXISyR55z2UtY+wSyw7iaZ3aY=; b=GxFCyvhakO0nbpiOox6ns/Tjbo3k+vDNjb9/4aWwPTBGBd7CIdqF298XemT9fB9yWlSNAc tOMV4Tyds1VsZTCQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Y7/b/PGh"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=GxFCyvha DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1748966938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gH0fPMGyXogjgY8zr8pXISyR55z2UtY+wSyw7iaZ3aY=; b=Y7/b/PGho6VDdsJDXrYmgwQzE0/DSWgapCpwxbc/4KBH2mAk7DmGJQraHNqxoEvRVofzQ5 ZO5/B1riz9mlnVOcfCHJEtHcfVsPwrqNQTgq0yFJeqzb4jpiXgC9pL1S//HEuRy36tTT2g keqqwAcMDzlo/kCiv7W2hylflM8NKW8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1748966938; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gH0fPMGyXogjgY8zr8pXISyR55z2UtY+wSyw7iaZ3aY=; b=GxFCyvhakO0nbpiOox6ns/Tjbo3k+vDNjb9/4aWwPTBGBd7CIdqF298XemT9fB9yWlSNAc tOMV4Tyds1VsZTCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 203AC13A92; Tue, 3 Jun 2025 16:08:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id y1KnNBkeP2hNRAAAD6G6ig (envelope-from ); Tue, 03 Jun 2025 16:08:57 +0000 From: Fabiano Rosas To: Peter Xu , qemu-devel@nongnu.org Cc: "Dr . David Alan Gilbert" , peterx@redhat.com, Alexey Perevalov , Juraj Marcin Subject: Re: [PATCH 09/13] migration/postcopy: Initialize blocktime context only until listen In-Reply-To: <20250527231248.1279174-10-peterx@redhat.com> References: <20250527231248.1279174-1-peterx@redhat.com> <20250527231248.1279174-10-peterx@redhat.com> Date: Tue, 03 Jun 2025 13:08:55 -0300 Message-ID: <8734cg4xk8.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: A065821216 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > Before this patch, the blocktime context can be created very early, because > postcopy_ram_supported_by_host() <- migrate_caps_check() can happen during > migration object init. > > The trick here is the blocktime context needs system vCPU information, > which seems to be possible to change after that point. I didn't verify it, > but it doesn't sound right. > > Now move it out and initialize the context only when postcopy listen > starts. That is already during a migration so it should be guaranteed the > vCPU topology can never change on both sides. > > While at it, assert that the ctx isn't created instead this time; the old > "if" trick isn't needed when we're sure it will only happen once now. > > Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas