Re: [PATCH 3/3] cleanup: Drop pointless label at end of function

["Alex Bennée" <alex.bennee@linaro.org>]

Markus Armbruster <armbru@redhat.com> writes:

> Corey Minyard <corey@minyard.net> writes:
>
>> Is this official coding style?  I'm not a big fan of having return
>> statements in the middle of functions, I generally only put them at
>> the beginning or the end.
>
> There's nothing in docs/devel/style.rst.
>
> I count more than 42,000 return statements with indentation > 4.  These
> are either within some block, or incorrectly indented.  I'd bet my own
> money that it's the former for pretty much all of them.
>
> I count less than 130 labels right before a return statement at end of a
> function.
>
> Based on that, I'd say return in the middle of function is
> overwhelmingly common in our code.

And with autofree variables it saves on clumsy goto and cleanup handlers.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro