From: Jani Nikula <jani.nikula@intel.com>
To: Masahiro Yamada <masahiroy@kernel.org>,
Maxime Ripard <mripard@kernel.org>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, simona.vetter@ffwll.ch,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/2] drm: ensure drm headers are self-contained and pass kernel-doc
Date: Thu, 13 Mar 2025 12:59:16 +0200 [thread overview]
Message-ID: <8734fhdwmz.fsf@intel.com> (raw)
In-Reply-To: <CAK7LNATYi5HPR+J0cdS33itHUdq5Qd+543X=z+AFyHxQssSJRw@mail.gmail.com>
On Sun, 09 Mar 2025, Masahiro Yamada <masahiroy@kernel.org> wrote:
> On Wed, Mar 5, 2025 at 10:59 PM Maxime Ripard <mripard@kernel.org> wrote:
>> As far as I'm concerned, I find this extremely helpful for DRM. If only
>> to ensure that the huge amount of work that went into cleaning up our
>> headers doesn't get lost.
>>
>> Nobody here claims that it should be enabled globally, just that it
>> should be enabled for DRM. We already have plenty of exceptions like
>> that for compiler flags, checkpatch, contribution process, etc. so I'm
>> not sure why those would be ok, but additional checks limited to a
>> subsystem wouldn't.
>>
>> Maxime
>
> Because we learned this feature is broken.
> It was broken under include/linux/, so it will be broken under include/drm/ too.
I don't think that's a valid conclusion.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-03-13 10:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 14:41 [PATCH 0/2] drm: add header tests Jani Nikula
2025-01-22 14:41 ` [PATCH 1/2] drm/client: include types.h to make drm_client_event.h self-contained Jani Nikula
2025-01-22 14:41 ` [PATCH 2/2] drm: ensure drm headers are self-contained and pass kernel-doc Jani Nikula
2025-03-02 16:01 ` Masahiro Yamada
2025-03-03 10:02 ` Jani Nikula
2025-03-03 12:59 ` Masahiro Yamada
2025-03-03 13:52 ` Jani Nikula
2025-03-04 18:05 ` Masahiro Yamada
2025-03-05 13:59 ` Maxime Ripard
2025-03-08 17:05 ` Masahiro Yamada
2025-03-13 10:59 ` Jani Nikula [this message]
2025-01-22 14:54 ` ✓ CI.Patch_applied: success for drm: add header tests Patchwork
2025-01-22 14:54 ` ✗ CI.checkpatch: warning " Patchwork
2025-01-22 14:55 ` ✓ CI.KUnit: success " Patchwork
2025-01-22 15:12 ` ✓ CI.Build: " Patchwork
2025-01-22 15:14 ` ✓ CI.Hooks: " Patchwork
2025-01-22 15:16 ` ✗ CI.checksparse: warning " Patchwork
2025-01-22 15:23 ` ✗ Fi.CI.CHECKPATCH: " Patchwork
2025-01-22 15:23 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-01-22 15:37 ` ✗ i915.CI.BAT: failure " Patchwork
2025-01-22 15:44 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-23 3:20 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-23 14:55 ` [PATCH 0/2] " Simona Vetter
2025-02-12 10:26 ` Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2024-08-23 14:11 [PATCH 1/2] drm/ttm: fix kernel-doc typo for @trylock_only Jani Nikula
2024-08-23 14:11 ` [PATCH 2/2] drm: ensure drm headers are self-contained and pass kernel-doc Jani Nikula
2024-08-26 16:05 ` kernel test robot
2024-08-26 22:28 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734fhdwmz.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=masahiroy@kernel.org \
--cc=mripard@kernel.org \
--cc=simona.vetter@ffwll.ch \
--cc=torvalds@linux-foundation.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.