All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: "Akihiko Odaki" <akihiko.odaki@daynix.com>,
	"Huang Rui" <ray.huang@amd.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Gert Wollny" <gert.wollny@collabora.com>,
	qemu-devel@nongnu.org,
	"Gurchetan Singh" <gurchetansingh@chromium.org>,
	"Alyssa Ross" <hi@alyssa.is>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Stefano Stabellini" <stefano.stabellini@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Xenia Ragiadakou" <xenia.ragiadakou@amd.com>,
	"Pierre-Eric Pelloux-Prayer" <pierre-eric.pelloux-prayer@amd.com>,
	"Honglei Huang" <honglei1.huang@amd.com>,
	"Julia Zhang" <julia.zhang@amd.com>,
	"Chen Jiqian" <Jiqian.Chen@amd.com>,
	"Rob Clark" <robdclark@gmail.com>,
	"Yiwei Zhang" <zzyiwei@chromium.org>,
	"Sergio Lopez Pascual" <slp@redhat.com>
Subject: Re: [PATCH v6 00/10] Support virtio-gpu DRM native context
Date: Fri, 14 Feb 2025 14:33:14 +0000	[thread overview]
Message-ID: <8734ggpped.fsf@draig.linaro.org> (raw)
In-Reply-To: <20250126201121.470990-1-dmitry.osipenko@collabora.com> (Dmitry Osipenko's message of "Sun, 26 Jan 2025 23:11:11 +0300")

Dmitry Osipenko <dmitry.osipenko@collabora.com> writes:

> This patchset adds DRM native context support to VirtIO-GPU on Qemu.
>
> Contarary to Virgl and Venus contexts that mediates high level GFX APIs,
> DRM native context [1] mediates lower level kernel driver UAPI, which
> reflects in a less CPU overhead and less/simpler code needed to support it.
> DRM context consists of a host and guest parts that have to be implemented
> for each GPU driver. On a guest side, DRM context presents a virtual GPU as
> a real/native host GPU device for GL/VK applications.
>
<snip>

So first the good news. I can now get this up and running (x86/kvm guest
with Intel graphics) and as far as I can tell the native context mode is
working. With Dongwon Kim's patch the mirroring/corruption I was seeing
is gone.

I can successfully run glmark2-wayland (although see bellow) but vkmark
completely fails to start reporting:

  MESA: info: virtgpu backend not enabling VIRTGPU_PARAM_CREATE_FENCE_PASSING
  MESA: info: virtgpu backend not enabling VIRTGPU_PARAM_CREATE_GUEST_HANDLE
  MESA: error: DRM_IOCTL_VIRTGPU_GET_CAPS failed with Invalid argument
  MESA: error: DRM_IOCTL_VIRTGPU_CONTEXT_INIT failed with Invalid argument, continuing without context...
  MESA: error: DRM_VIRTGPU_RESOURCE_CREATE_BLOB failed with No space left on device
  MESA: error: Failed to create virtgpu AddressSpaceStream
  MESA: error: vulkan: Failed to get host connection
  MESA: error: DRM_VIRTGPU_RESOURCE_CREATE_BLOB failed with No space left on device
  MESA: error: Failed to create virtgpu AddressSpaceStream
  MESA: error: vulkan: Failed to get host connection
  MESA: error: DRM_VIRTGPU_RESOURCE_CREATE_BLOB failed with No space left on device
  MESA: error: Failed to create virtgpu AddressSpaceStream
  MESA: error: vulkan: Failed to get host connection
  MESA: warning: ../src/gfxstream/guest/vulkan/gfxstream_vk_device.cpp:681: VK_ERROR_DEVICE_LOST
  MESA: error: DRM_VIRTGPU_RESOURCE_CREATE_BLOB failed with No space left on device
  MESA: error: Failed to create virtgpu AddressSpaceStream
  MESA: error: vulkan: Failed to get host connection
  MESA: warning: ../src/gfxstream/guest/vulkan/gfxstream_vk_device.cpp:332: VK_ERROR_DEVICE_LOST
  === Physical Device 0 ===
      Vendor ID:      0x8086
      Device ID:      0xA780
      Device Name:    Intel(R) Graphics (RPL-S)
      Driver Version: 101068899
      Device UUID:    b39e1cf39b101489e3c6039406f78d6c

I was booting with 4G of shared memory.

Later versions of vkmark (2025.01) fail due to missing the
VK_KHR_display extension required as of
https://github.com/vkmark/vkmark/commit/7c3189c6482cb84c3c0e69d6dabb9d80e0c0092a

> # Note about known performance problem in Qemu:
>
> DRM contexts are mapping host blobs extensively and these mapping
> operations work slowly in Qemu. Exact reason is unknown. Mappings work
> fast on Crosvm For DRM contexts this problem is more visible than for
> Venus/Virgl.

And how!

With drm_native I get a lot of stutter while running and barely 100FPS
(compared to ~8000 on pure venus). IMHO we need to figure out why there
is such a discrepancy before merging because currently it makes more
sense to use Venus. 

<snip>

I'll do some more testing with my AMD/Aarch64 rig next week.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


  parent reply	other threads:[~2025-02-14 14:33 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-26 20:11 [PATCH v6 00/10] Support virtio-gpu DRM native context Dmitry Osipenko
2025-01-26 20:11 ` [PATCH v6 01/10] ui/sdl2: Restore original context after new context creation Dmitry Osipenko
2025-01-26 20:11 ` [PATCH v6 02/10] ui/sdl2: Implement dpy dmabuf functions Dmitry Osipenko
2025-01-26 20:11 ` [PATCH v6 03/10] virtio-gpu: Handle virgl fence creation errors Dmitry Osipenko
2025-01-26 20:11 ` [PATCH v6 04/10] virtio-gpu: Support asynchronous fencing Dmitry Osipenko
2025-01-27 16:18   ` Alex Bennée
2025-01-26 20:11 ` [PATCH v6 05/10] virtio-gpu: Support DRM native context Dmitry Osipenko
2025-01-26 20:11 ` [PATCH v6 06/10] ui/sdl2: Don't disable scanout when display is refreshed Dmitry Osipenko
2025-01-26 20:11 ` [PATCH v6 07/10] ui/gtk: " Dmitry Osipenko
2025-01-26 20:11 ` [PATCH v6 08/10] docs/system: virtio-gpu: Add link to Mesa VirGL doc Dmitry Osipenko
2025-01-26 20:11 ` [PATCH v6 09/10] docs/system: virtio-gpu: Update Venus link Dmitry Osipenko
2025-01-26 20:11 ` [PATCH v6 10/10] docs/system: virtio-gpu: Document host/guest requirements Dmitry Osipenko
2025-01-27  6:28   ` Akihiko Odaki
2025-01-27  9:45     ` Alex Bennée
2025-01-28  6:20       ` Akihiko Odaki
2025-01-31 17:17     ` Dmitry Osipenko
2025-01-29  1:18   ` Gurchetan Singh
2025-01-31 17:19     ` Dmitry Osipenko
2025-02-02 22:16       ` Dmitry Osipenko
2025-01-27 16:17 ` [PATCH v6 00/10] Support virtio-gpu DRM native context Alex Bennée
2025-01-31 17:13   ` Dmitry Osipenko
2025-02-17 15:18     ` Alex Bennée
2025-02-02 15:17   ` Dmitry Osipenko
2025-02-03  9:07     ` Alex Bennée
2025-02-03 18:15       ` Kim, Dongwon
2025-02-03 19:31         ` Alex Bennée
2025-02-04  1:51           ` Kim, Dongwon
2025-02-05 18:37             ` Dmitry Osipenko
2025-02-05 18:53               ` Kim, Dongwon
2025-02-05 20:08                 ` Dmitry Osipenko
2025-02-05 22:13                   ` Dmitry Osipenko
2025-02-12  2:46                     ` Dmitry Osipenko
2025-02-14  6:03                       ` Kasireddy, Vivek
2025-02-14 14:33 ` Alex Bennée [this message]
2025-02-14 16:03   ` Dmitry Osipenko
2025-02-17 15:22     ` Alex Bennée
2025-02-17 18:02       ` Dmitry Osipenko
2025-02-17 18:35         ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734ggpped.fsf@draig.linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=Jiqian.Chen@amd.com \
    --cc=akihiko.odaki@daynix.com \
    --cc=alexander.deucher@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dmitry.osipenko@collabora.com \
    --cc=gert.wollny@collabora.com \
    --cc=gurchetansingh@chromium.org \
    --cc=hi@alyssa.is \
    --cc=honglei1.huang@amd.com \
    --cc=julia.zhang@amd.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=pierre-eric.pelloux-prayer@amd.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ray.huang@amd.com \
    --cc=robdclark@gmail.com \
    --cc=roger.pau@citrix.com \
    --cc=slp@redhat.com \
    --cc=stefano.stabellini@amd.com \
    --cc=xenia.ragiadakou@amd.com \
    --cc=zzyiwei@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.