From: Toon Claes <toon@iotcl.com>
To: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Cc: Justin Tobler <jltobler@gmail.com>
Subject: Re: [PATCH v2 07/13] meson: drop separate version library
Date: Fri, 07 Feb 2025 14:24:42 +0100 [thread overview]
Message-ID: <8734gp51lx.fsf@iotcl.com> (raw)
In-Reply-To: <20250130-b4-pks-meson-improvements-v2-7-2f05581ffb44@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> When building `libgit.a` we link it against a `libgit_version.a` library
> that contains the version information that we inject at build time. The
> intent of this is to avoid rebuilding all of `libgit.a` whenever the
> version changes. But that wouldn't happen in the first place, as we know
> to just rebuild the files that depend on the generated "version-def.h"
> file.
>
> This is an artifact of an earlier version of the Meson build infra that
> didn't ultimately land. We didn't yet have "version-def.h", and instead
> injected the version via preprocessor directives. And here we would have
> rebuilt all of `libgit.a` indeed in case the version changes, because
> the preprocessor directive applied to all files.
>
> Stop building the separate library and instead add "version-def.h" to
> the list of source files directly.
I'm happy to see this "optimazation" go. The solution using
"version-def.h" seems simpler and more straightforward. Thanks!
--
Toon
next prev parent reply other threads:[~2025-02-07 13:25 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 7:11 [PATCH 00/11] meson: cleanups, improvements, smallish fixes Patrick Steinhardt
2025-01-29 7:11 ` [PATCH 01/11] meson: fix exec path with enabled runtime prefix Patrick Steinhardt
2025-01-29 20:12 ` Justin Tobler
2025-01-30 7:06 ` Patrick Steinhardt
2025-01-29 7:11 ` [PATCH 02/11] meson: inline the static 'git' library Patrick Steinhardt
2025-01-29 7:11 ` [PATCH 03/11] meson: simplify use of the common-main library Patrick Steinhardt
2025-01-29 7:11 ` [PATCH 04/11] meson: stop linking libcurl into all executables Patrick Steinhardt
2025-01-29 7:11 ` [PATCH 05/11] meson: introduce `libgit_curl` dependency Patrick Steinhardt
2025-01-29 7:11 ` [PATCH 06/11] meson: drop separate version library Patrick Steinhardt
2025-01-29 7:12 ` [PATCH 07/11] meson: deduplicate the list of required programs Patrick Steinhardt
2025-01-29 20:28 ` Justin Tobler
2025-01-29 7:12 ` [PATCH 08/11] meson: simplify setup of PATH environment variable Patrick Steinhardt
2025-01-29 20:42 ` Justin Tobler
2025-01-30 7:06 ` Patrick Steinhardt
2025-01-29 7:12 ` [PATCH 09/11] meson: prevent finding sed(1) in a loop Patrick Steinhardt
2025-01-29 7:12 ` [PATCH 10/11] meson: fix overwritten `git` variable Patrick Steinhardt
2025-01-29 7:12 ` [PATCH 11/11] meson: consistently use custom program paths to resolve programs Patrick Steinhardt
2025-01-30 14:43 ` [PATCH v2 00/13] meson: cleanups, improvements, smallish fixes Patrick Steinhardt
2025-01-30 14:43 ` [PATCH v2 01/13] meson: fix exec path with enabled runtime prefix Patrick Steinhardt
2025-01-30 14:43 ` [PATCH v2 02/13] meson: fix OpenSSL fallback when not explicitly required Patrick Steinhardt
2025-01-30 14:43 ` [PATCH v2 03/13] meson: inline the static 'git' library Patrick Steinhardt
2025-01-30 14:43 ` [PATCH v2 04/13] meson: simplify use of the common-main library Patrick Steinhardt
2025-01-30 14:43 ` [PATCH v2 05/13] meson: introduce `libgit_curl` dependency Patrick Steinhardt
2025-01-30 14:43 ` [PATCH v2 06/13] meson: stop linking libcurl into all executables Patrick Steinhardt
2025-01-30 14:43 ` [PATCH v2 07/13] meson: drop separate version library Patrick Steinhardt
2025-02-07 13:24 ` Toon Claes [this message]
2025-01-30 14:44 ` [PATCH v2 08/13] meson: improve PATH handling Patrick Steinhardt
2025-01-30 14:44 ` [PATCH v2 09/13] meson: improve handling of `sane_tool_path` option Patrick Steinhardt
2025-02-07 13:49 ` Toon Claes
2025-02-07 14:29 ` Patrick Steinhardt
2025-01-30 14:44 ` [PATCH v2 10/13] meson: prevent finding sed(1) in a loop Patrick Steinhardt
2025-01-30 14:44 ` [PATCH v2 11/13] meson: fix overwritten `git` variable Patrick Steinhardt
2025-01-30 14:44 ` [PATCH v2 12/13] meson: consistently use custom program paths to resolve programs Patrick Steinhardt
2025-01-30 14:44 ` [PATCH v2 13/13] gitlab-ci: restrict maximum number of link jobs on Windows Patrick Steinhardt
2025-02-07 15:22 ` [PATCH v2 00/13] meson: cleanups, improvements, smallish fixes Justin Tobler
2025-02-26 8:22 ` [PATCH v3 " Patrick Steinhardt
2025-02-26 8:22 ` [PATCH v3 01/13] meson: fix exec path with enabled runtime prefix Patrick Steinhardt
2025-02-26 8:22 ` [PATCH v3 02/13] meson: fix OpenSSL fallback when not explicitly required Patrick Steinhardt
2025-02-26 8:22 ` [PATCH v3 03/13] meson: inline the static 'git' library Patrick Steinhardt
2025-02-26 8:22 ` [PATCH v3 04/13] meson: simplify use of the common-main library Patrick Steinhardt
2025-02-26 8:22 ` [PATCH v3 05/13] meson: introduce `libgit_curl` dependency Patrick Steinhardt
2025-02-26 8:22 ` [PATCH v3 06/13] meson: stop linking libcurl into all executables Patrick Steinhardt
2025-02-26 8:22 ` [PATCH v3 07/13] meson: drop separate version library Patrick Steinhardt
2025-02-26 8:22 ` [PATCH v3 08/13] meson: improve PATH handling Patrick Steinhardt
2025-02-26 8:22 ` [PATCH v3 09/13] meson: improve handling of `sane_tool_path` option Patrick Steinhardt
2025-02-26 8:22 ` [PATCH v3 10/13] meson: prevent finding sed(1) in a loop Patrick Steinhardt
2025-02-26 8:22 ` [PATCH v3 11/13] meson: fix overwritten `git` variable Patrick Steinhardt
2025-02-26 8:22 ` [PATCH v3 12/13] meson: consistently use custom program paths to resolve programs Patrick Steinhardt
2025-02-26 8:22 ` [PATCH v3 13/13] gitlab-ci: restrict maximum number of link jobs on Windows Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734gp51lx.fsf@iotcl.com \
--to=toon@iotcl.com \
--cc=git@vger.kernel.org \
--cc=jltobler@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.