All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/i915/dp_mst: Use intel_display::platform.alderlake_p instead of IS_ALDERLAKE_P()
Date: Wed, 08 Jan 2025 19:02:57 +0200	[thread overview]
Message-ID: <8734htkzlq.fsf@intel.com> (raw)
In-Reply-To: <20250108151916.491113-6-imre.deak@intel.com>

On Wed, 08 Jan 2025, Imre Deak <imre.deak@intel.com> wrote:
> Use the driver's standard intel_display::platform.alderlake_p instead of
> IS_ALDERLAKE_P().
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index fbc504037a969..e422e4ee9d280 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -1219,11 +1219,10 @@ static void mst_stream_pre_enable(struct intel_atomic_state *state,
>  static void enable_bs_jitter_was(const struct intel_crtc_state *crtc_state)
>  {
>  	struct intel_display *display = to_intel_display(crtc_state);
> -	struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev);
>  	u32 clear = 0;
>  	u32 set = 0;
>  
> -	if (!IS_ALDERLAKE_P(i915))
> +	if (!display->platform.alderlake_p)
>  		return;
>  
>  	if (!IS_DISPLAY_STEP(display, STEP_D0, STEP_FOREVER))

-- 
Jani Nikula, Intel

  reply	other threads:[~2025-01-08 17:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08 15:19 [PATCH 0/4] drm/i915/dp_mst: Fix error handling/clean up pointer use Imre Deak
2025-01-08 15:19 ` [PATCH 1/5] drm/i915/dp_mst: Fix error handling while adding a connector Imre Deak
2025-01-08 15:19 ` [PATCH 2/5] drm/i915/dp_mst: Use intel_connector vs. drm_connector pointer in intel_dp_mst.c Imre Deak
2025-01-08 15:19 ` [PATCH 3/5] drm/i915/dp_mst: Simplify using to_intel_display() passing it an intel_connector pointer Imre Deak
2025-01-08 17:01   ` Jani Nikula
2025-01-08 15:19 ` [PATCH 4/5] drm/i915/dp_mst: Simplify getting a drm_device pointer needed by to_i915() Imre Deak
2025-01-08 17:02   ` Jani Nikula
2025-01-08 15:19 ` [PATCH 5/5] drm/i915/dp_mst: Use intel_display::platform.alderlake_p instead of IS_ALDERLAKE_P() Imre Deak
2025-01-08 17:02   ` Jani Nikula [this message]
2025-01-08 17:30 ` ✗ i915.CI.BAT: failure for drm/i915/dp_mst: Fix error handling/clean up pointer use Patchwork
2025-01-08 18:25   ` Imre Deak
2025-01-10 15:43 ` ✓ i915.CI.BAT: success for drm/i915/dp_mst: Fix error handling/clean up pointer use (rev2) Patchwork
2025-01-13 13:26   ` Imre Deak
2025-01-14 17:25 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734htkzlq.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.