From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A01AAD43341 for ; Thu, 7 Nov 2024 11:18:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t90WC-0008KQ-QF; Thu, 07 Nov 2024 06:17:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t90W4-0008K0-Rs for qemu-devel@nongnu.org; Thu, 07 Nov 2024 06:17:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t90W2-0004Hb-S2 for qemu-devel@nongnu.org; Thu, 07 Nov 2024 06:17:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730978248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zqtP3PbVxgiCGatbh2Gh3VIBlykuo2jURlxbRlGYmlc=; b=Vsw8o9LjhGgP+cSJgyNKPMyBMdc5pFn2yFiXVULGMYp9usrcUt5ngOtH14M+JjzYu6yLhg LBB79r11/2JfK0b/l+NF1hG56I6vwIV9kr9+UlUWlNjCa24BeTwelkB4hyEzgfH55XZmJe 6RsTkG5vKzjNwygEEDkKndXdoPIDtm4= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-498-_n_hPHSmNqWyNf0S1oLs7Q-1; Thu, 07 Nov 2024 06:17:27 -0500 X-MC-Unique: _n_hPHSmNqWyNf0S1oLs7Q-1 X-Mimecast-MFC-AGG-ID: _n_hPHSmNqWyNf0S1oLs7Q Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 87B901956080 for ; Thu, 7 Nov 2024 11:17:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.150]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 49215196BC05 for ; Thu, 7 Nov 2024 11:17:24 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6C36621E6A28; Thu, 7 Nov 2024 12:17:21 +0100 (CET) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: Markus Armbruster , qemu-devel@nongnu.org, Paolo Bonzini , Eric Blake Subject: Re: [PATCH] crypto: purge 'loaded' property that was documented as already removed In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Tue, 5 Nov 2024 15:07:11 +0000") References: <20241030084718.2980247-1-berrange@redhat.com> <874j4nzagr.fsf@pond.sub.org> Date: Thu, 07 Nov 2024 12:17:21 +0100 Message-ID: <8734k3l2da.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.34, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > On Mon, Nov 04, 2024 at 09:09:40AM +0100, Markus Armbruster wrote: >> Daniel P. Berrang=C3=A9 writes: >>=20 >> > The 'loaded' property on TLS creds and secret objects was marked as >> > deprected in 6.0.0 and then marked as removed in 7.1.0. >>=20 >> deprecated >>=20 >> Regarding "marked as removed": not quite. Its entry was moved from >> docs/about/deprecated.rst to docs/about/removed-features.rst, but the >> text there is "should simply be removed." >>=20 >> > >> > Except it wasn't actually removed, it was just made read-only, while >> > claiming it was removed. Finish the long overdue removal job. >> > >> > Fixes: 0310641c06dd5f7ea031b2b6170cb2edc63e4cea >>=20 >> I'm not sure it fixes something that was broken. Commit 0310641c06d >> (crypto: make loaded property read-only) did what it said on the tin. >> What it did was unusual, and maybe a bad idea. > > I'm re-wording the commit message to: > > The 'loaded' property on TLS creds and secret objects was marked as > deprecated in 6.0.0. In 7.1.0 the deprecation info was moved into > the 'removed-features.rst' file, but the property was not actually > removed, just made read-only. This was a highly unusual practice, > so finish the long overdue removal job. > > and removing the "Fixes" tag Thanks! [...]