From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56B74D3A67B for ; Tue, 29 Oct 2024 18:48:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t5rGW-0005Gs-8e; Tue, 29 Oct 2024 14:48:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5rGU-0005Ga-W2 for qemu-devel@nongnu.org; Tue, 29 Oct 2024 14:48:27 -0400 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t5rGT-0008N8-Fh for qemu-devel@nongnu.org; Tue, 29 Oct 2024 14:48:26 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F3F711F799; Tue, 29 Oct 2024 18:48:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1730227704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qiv5dnWp2y4zzgP67W1x1kCUY7hfm0cjd8RxgMjSt9c=; b=Rc2JIFRF5yBMyHhDiIay3+XVwIdPR3BiApdsfiNsPT+0TKB0x1oYAM/efITz46Aq4RPOsI VL9tssjOsuwh2dPiW+MMI1lPan+Xgyl71vqjBGCgo1AJZLzl1fUHYNNx/JVLSWW0cWRG4K YQTGwoJA+BZcHpiTon8qZBRdLPpfGPw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1730227704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qiv5dnWp2y4zzgP67W1x1kCUY7hfm0cjd8RxgMjSt9c=; b=eYT49oXQ7XK9ER2Dii/Z90BdtjP40wxUXen0F+EbBec2PnDfKcgNDnp/n6QnR007Rp5coE Zt3QMWcGH0TQy+DQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Rc2JIFRF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=eYT49oXQ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1730227704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qiv5dnWp2y4zzgP67W1x1kCUY7hfm0cjd8RxgMjSt9c=; b=Rc2JIFRF5yBMyHhDiIay3+XVwIdPR3BiApdsfiNsPT+0TKB0x1oYAM/efITz46Aq4RPOsI VL9tssjOsuwh2dPiW+MMI1lPan+Xgyl71vqjBGCgo1AJZLzl1fUHYNNx/JVLSWW0cWRG4K YQTGwoJA+BZcHpiTon8qZBRdLPpfGPw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1730227704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qiv5dnWp2y4zzgP67W1x1kCUY7hfm0cjd8RxgMjSt9c=; b=eYT49oXQ7XK9ER2Dii/Z90BdtjP40wxUXen0F+EbBec2PnDfKcgNDnp/n6QnR007Rp5coE Zt3QMWcGH0TQy+DQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7D59E136A5; Tue, 29 Oct 2024 18:48:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 9JwBEfctIWd+TAAAD6G6ig (envelope-from ); Tue, 29 Oct 2024 18:48:23 +0000 From: Fabiano Rosas To: Peter Xu , qemu-devel@nongnu.org Cc: Avihai Horon , =?utf-8?Q?C=C3=A9dric?= Le Goater , peterx@redhat.com, Alex Williamson Subject: Re: [PATCH v3 2/8] migration: Unexport dirty_bitmap_mig_init() In-Reply-To: <20241024213056.1395400-3-peterx@redhat.com> References: <20241024213056.1395400-1-peterx@redhat.com> <20241024213056.1395400-3-peterx@redhat.com> Date: Tue, 29 Oct 2024 15:48:21 -0300 Message-ID: <8734ked9u2.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: F3F711F799 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:email,suse.de:dkim,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > It's only used within migration/, so it shouldn't be exported. > > Reviewed-by: C=C3=A9dric Le Goater > Signed-off-by: Peter Xu > --- > include/migration/misc.h | 3 --- > migration/migration.h | 4 ++++ > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/include/migration/misc.h b/include/migration/misc.h > index bfadc5613b..df57be6b5e 100644 > --- a/include/migration/misc.h > +++ b/include/migration/misc.h > @@ -108,7 +108,4 @@ bool migration_incoming_postcopy_advised(void); > /* True if background snapshot is active */ > bool migration_in_bg_snapshot(void); >=20=20 > -/* migration/block-dirty-bitmap.c */ > -void dirty_bitmap_mig_init(void); > - > #endif > diff --git a/migration/migration.h b/migration/migration.h > index 7dc59c5e8d..0956e9274b 100644 > --- a/migration/migration.h > +++ b/migration/migration.h > @@ -552,4 +552,8 @@ int migration_rp_wait(MigrationState *s); > void migration_rp_kick(MigrationState *s); >=20=20 > void migration_bitmap_sync_precopy(bool last_stage); > + > +/* migration/block-dirty-bitmap.c */ > +void dirty_bitmap_mig_init(void); > + > #endif Reviewed-by: Fabiano Rosas