From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org,
Dmitry Antipov <dmantipov@yandex.ru>,
syzbot+93cbd5fbb85814306ba1@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] wifi: ath9k: fix out-of-bounds endpoint index in htc_issue_send()
Date: Fri, 25 Oct 2024 11:41:37 +0200 [thread overview]
Message-ID: <8734kkfrji.fsf@toke.dk> (raw)
In-Reply-To: <20241025054020.207044-1-dmantipov@yandex.ru>
Dmitry Antipov <dmantipov@yandex.ru> writes:
> Syzbot has reported the following UBSAN splat:
>
> UBSAN: array-index-out-of-bounds in drivers/net/wireless/ath/ath9k/htc_hst.c:26:35
> index 255 is out of range for type 'struct htc_endpoint[22]'
> ...
> Call Trace:
> ...
> __ubsan_handle_out_of_bounds+0x115/0x140
> htc_send_epid+0x1e0/0x2d0
> ath9k_wmi_cmd+0x31f/0x590
> ath9k_regread+0xdc/0x140
> ? __pfx_ath9k_regread+0x10/0x10
> ? _raw_spin_unlock_irqrestore+0xae/0x110
> ? __pfx__raw_spin_unlock_irqrestore+0x10/0x10
> ? __pfx_ath9k_regread+0x10/0x10
> ath9k_hw_init+0x4b0/0x2230
> ? init_timer_key+0x171/0x2d0
> ath9k_htc_probe_device+0xa66/0x1fe0
> ? __pfx_ath9k_htc_probe_device+0x10/0x10
> ? usb_hcd_submit_urb+0x345/0x1ae0
> ? usb_free_urb+0x9d/0x120
> ? ath9k_hif_usb_alloc_urbs+0x1077/0x1150
> ath9k_htc_hw_init+0x32/0x70
> ath9k_hif_usb_firmware_cb+0x240/0x4c0
> ? __pfx_ath9k_hif_usb_firmware_cb+0x10/0x10
> request_firmware_work_func+0x106/0x1c0
> ...
>
> IIUC https://syzkaller.appspot.com/text?tag=ReproC&x=1734b9f1180000 makes
> an attempt to emulate ath9k USB device in somewhat weird and obscure way
> so I'm not sure whether this may happen on a real hardware. OTOH whether
> ending with ENDPOINT_UNUSED in 'htc_connect_service()' may indicate the
> malfunctioned real device, it may be better to reject such a device with
> -ENODEV.
>
> Reported-by: syzbot+93cbd5fbb85814306ba1@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=93cbd5fbb85814306ba1
> Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Heh, so pwcli was complaining that the patch doesn't apply, which turns
out to be because of this fix for the same thing:
8619593634cb ("wifi: ath9k: add range check for conn_rsp_epid in htc_connect_service()")
So dropping this...
-Toke
prev parent reply other threads:[~2024-10-25 9:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 5:40 [PATCH v2] wifi: ath9k: fix out-of-bounds endpoint index in htc_issue_send() Dmitry Antipov
2024-10-25 9:41 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734kkfrji.fsf@toke.dk \
--to=toke@toke.dk \
--cc=dmantipov@yandex.ru \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=syzbot+93cbd5fbb85814306ba1@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.