From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: James Hilliard <james.hilliard1@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] utils/genrandconfig: fix fallout of dropping toolchain CSV
Date: Wed, 18 Sep 2024 13:11:49 +0200 [thread overview]
Message-ID: <8734lxtdvu.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20240820064531.3680998-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Tue, 20 Aug 2024 08:45:31 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Commit 2f260084d577 (utils/genrandconfig: remove support for toolchain
> CSV) kept the --no-toolchains-csv option, but in the rework forgot to
> keep it as a bool, while argparse default is to expect a string.
> Rather than re-introduce the action="store_true" which implies the
> argument is a bool, explicit make it a bool.
> Fixes: 2f260084d5771728f3340ff6a86a23391133a635
> Reported-by: James Hilliard <james.hilliard1@gmail.com>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2024.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-09-18 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 6:45 [Buildroot] [PATCH] utils/genrandconfig: fix fallout of dropping toolchain CSV Yann E. MORIN
2024-08-20 21:22 ` Thomas Petazzoni via buildroot
2024-09-18 11:11 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734lxtdvu.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.