Re: [PATCH] drm/xe/oa: Insert wmb/sfence before enabling OA

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Tue, 10 Sep 2024 03:14:54 -0700, Jani Nikula wrote:
>
> On Mon, 09 Sep 2024, Ashutosh Dixit <ashutosh.dixit@intel.com> wrote:
> > We are occasionally seeing that OA Buffer register is not programmed (has
> > value 0) when OA is enabled. This means OA has been enabled before it has
> > been fully configured. Or, the register write enabling OA has overtaken
> > previous OA configuration register writes.
> >
> > Therefore, insert a wmb/sfence to preserve OA register write ordering
> > before enabling OA.
> >
> > v2: s/wmb()/xe_device_wmb()/
> >
> > Fixes: e936f885f1e9 ("drm/xe/oa/uapi: Expose OA stream fd")
> > Reported-by: Guy Zadicario <guy.zadicario@intel.com>
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > Cc: stable@vger.kernel.org
>
> Please do not resend patches just to tweak something in the commit
> message. It can be fixed while applying. Or when you have to make
> another version with actual functional changes.
>
> Please appreciate that this uses a full CI test run. It's not an
> unlimited resource.

OK, yeah, sorry, this patch especially was a bit excessive.