All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Mike Lothian <mike@fireburn.co.uk>
Cc: Bert Karwatzki <spasswolf@web.de>,
	 Linux regressions mailing list <regressions@lists.linux.dev>,
	 sean.wang@kernel.org,  nbd@nbd.name,
	lorenzo.bianconi@redhat.com,  sean.wang@mediatek.com,
	deren.wu@mediatek.com,  mingyen.hsieh@mediatek.com,
	linux-wireless@vger.kernel.org,
	 linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] wifi: mt76: mt7921: fix null pointer access in mt792x_mac_link_bss_remove
Date: Thu, 05 Sep 2024 16:33:24 +0300	[thread overview]
Message-ID: <8734mecjiz.fsf@kernel.org> (raw)
In-Reply-To: <CAHbf0-HbLRRhtUEj1TDzemePoaLo71sxMFDN526HPEB_zO+4ow@mail.gmail.com> (Mike Lothian's message of "Thu, 29 Aug 2024 17:52:36 +0100")

Mike Lothian <mike@fireburn.co.uk> writes:

>> > this seems to be exactly the same error as I had (It can also be actively
>> > provoked by "nmcli radio wifi off"), but in my case commit 479ffee68d59c599 is
>> > enough to fix the issue. Can you please double check that your faulty kernel
>> > does not include this commit. If it does and you still get the error I can post
>> > the fix to the list.
>>
>> 479ffee68d59c599 isn't enough to fix it here, I've been applying the
>> second patch since it was pointed out
>
> Sorry I've gotten myself confused as the patches changed
>
> My kernel with
> 6557a28f3e3a54cff4f0dcdd1dfa649b26557ab3
> 479ffee68d59c599f8aed8fa2dcc8e13e7bd13c3
>
> Is enough to fix things
>
> I've been applying  the old fix on top which was only applying
>
> @@ -1206,6 +1206,9 @@ static void mt7921_ipv6_addr_change(struct
> ieee80211_hw *hw,
>                },
>        };
>
> +       if (!mvif->phy)
> +               return;
> +
>        read_lock_bh(&idev->lock);
>        list_for_each_entry(ifa, &idev->addr_list, if_list) {
>                if (ifa->flags & IFA_F_TENTATIVE)
>
> Casing it to be rebuilt each time

So just to confirm: all fixes are now applied to the tree and we don't
have any missing fixes?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


      reply	other threads:[~2024-09-05 13:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18 23:46 [PATCH] wifi: mt76: mt7921: fix null pointer access in mt792x_mac_link_bss_remove sean.wang
2024-07-19 11:26 ` Bert Karwatzki
2024-07-24  9:36 ` Linux regression tracking (Thorsten Leemhuis)
2024-07-29 10:51   ` Bert Karwatzki
2024-07-29 13:49     ` Linux regression tracking (Thorsten Leemhuis)
2024-08-01 12:38   ` Mike Lothian
2024-08-01 16:57     ` Bert Karwatzki
2024-08-27 16:30       ` Mike Lothian
2024-08-27 21:13         ` Bert Karwatzki
2024-08-27 23:38           ` Mike Lothian
2024-08-28  8:17             ` Bert Karwatzki
2024-08-28 15:20               ` Mike Lothian
2024-08-28 17:05                 ` Bert Karwatzki
2024-08-29 16:35                   ` Mike Lothian
2024-08-29 16:52                     ` Mike Lothian
2024-09-05 13:33                       ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734mecjiz.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=deren.wu@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=mike@fireburn.co.uk \
    --cc=mingyen.hsieh@mediatek.com \
    --cc=nbd@nbd.name \
    --cc=regressions@lists.linux.dev \
    --cc=sean.wang@kernel.org \
    --cc=sean.wang@mediatek.com \
    --cc=spasswolf@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.