From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CE4DC52D6F for ; Wed, 7 Aug 2024 11:22:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbejm-0004XT-F4; Wed, 07 Aug 2024 07:21:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbeja-0004WG-3g for qemu-devel@nongnu.org; Wed, 07 Aug 2024 07:21:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbejW-0000VP-Fe for qemu-devel@nongnu.org; Wed, 07 Aug 2024 07:21:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723029692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2tx5hlmYZvraKIzw1jD9lof75iffe8YeSlJbet7Yp7I=; b=hCNRLMequ88SqFJkZfe3tKg3RSaGTVl7L9R3QGMh1AVQuuVkWajJpLNKahKRd7hcIq9yQ0 f9vJvPNQEVPn3DZrYpxPX4aub/vpDtEHhYaZHDBQxnPH1kPjyPEHKzkI5j6SPjlLKtvo2X GrCm1ytiN5ErDz/eTE14352p/PzwrOA= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-539-SJzgX90vN0yo6CHB3P1_pA-1; Wed, 07 Aug 2024 07:21:29 -0400 X-MC-Unique: SJzgX90vN0yo6CHB3P1_pA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6F14E1955D44; Wed, 7 Aug 2024 11:21:28 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.245]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0237919560A3; Wed, 7 Aug 2024 11:21:28 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E270B21E668F; Wed, 7 Aug 2024 13:21:25 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Michael Roth , Paolo Bonzini Subject: Re: [RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Wed, 7 Aug 2024 12:00:21 +0100") References: <20240807093406.40360-1-philmd@linaro.org> <87ttfwwqrx.fsf@pond.sub.org> Date: Wed, 07 Aug 2024 13:21:25 +0200 Message-ID: <8734ngwpca.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.144, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > On Wed, Aug 07, 2024 at 12:50:26PM +0200, Markus Armbruster wrote: >> Daniel P. Berrang=C3=A9 writes: [...] >> > It is confusing that we have both shared stuff and QMP schema >> > only stuff under the same location. >>=20 >> Which stuff in which location? > > There are multiple directories with 'qapi' in their name > > - $SRC/include/qapi - all generic stuff for any consumer of QAPI > - $SRC/qapi - impl of generic stuff from $SRC/include/qapi, but > also the QMP schema for machine emulator > - $BUILD/qapi - generated code for QMP schema for machine emulator - scripts/qapi - the generator code > > I find it confusing that we have both generic QAPI code and the main > machine emulator QMP schema in directories sharing the same 'qapi' > name. Got it. Lack of separation between generic C infrastructure and specific schema hasn't really annoyed me. Possibly because the two are, for better or worse, joined at the hip. Except for the use of "qapi:" in commit message titles; there I've at times felt a slight urge to distinguish between schema work, C infrastructure work, and generator work. Of course, other people's confusion trumps my non-annoyance.