All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Takashi Iwai <tiwai@suse.de>,
	stable@vger.kernel.org, Edmund Raile <edmund.raile@proton.me>
Subject: Re: [PATCH] ALSA: firewire-lib: fix wrong value as length of header for CIP_NO_HEADER case
Date: Thu, 25 Jul 2024 19:52:32 +0200	[thread overview]
Message-ID: <8734nxickf.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240725162537.GB109922@workstation.local>

On Thu, 25 Jul 2024 18:25:37 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Thu, Jul 25, 2024 at 10:16:36AM -0600, Gustavo A. R. Silva wrote:
> > Yes, but why have two separate patches when the root cause can be addressed by
> > a single one, which will prevent other potential issues from occurring?
> > 
> > The main issue in this case is the __counted_by() annotation. The DEFINE_FLEX()
> > bug was a consequence.
> 
> Just now I sent a patch to revert the issued commit[1].
> 
> I guess that we need the association between the two fixes. For example,
> we can append more 'Fixes' tag to the patch in sound subsystem into the
> patch in firewire subsystem (or vice versa).

OK, then I drop your patch for the sound stuff, and you can take it
through firewire tree.

Feel free to take my ack:
Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi

  reply	other threads:[~2024-07-25 17:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25 15:56 [PATCH] ALSA: firewire-lib: fix wrong value as length of header for CIP_NO_HEADER case Takashi Sakamoto
2024-07-25 16:07 ` Takashi Iwai
2024-07-25 16:08 ` Gustavo A. R. Silva
2024-07-25 16:11   ` Takashi Iwai
2024-07-25 16:16     ` Gustavo A. R. Silva
2024-07-25 16:25       ` Takashi Sakamoto
2024-07-25 17:52         ` Takashi Iwai [this message]
2024-07-26  0:20           ` Takashi Sakamoto
2024-07-27  1:35 ` Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734nxickf.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=edmund.raile@proton.me \
    --cc=gustavo@embeddedor.com \
    --cc=o-takashi@sakamocchi.jp \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.