From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] Revert "package/gnutls: add tpm2-tss optional dependency"
Date: Sun, 21 Jul 2024 12:39:46 +0300 [thread overview]
Message-ID: <8734o3ozh9.fsf@tarshish> (raw)
In-Reply-To: <20240721090024.371743-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Sun, 21 Jul 2024 11:00:24 +0200")
Hi Fabrice,
On Sun, Jul 21 2024, Fabrice Fontaine wrote:
> This reverts commit caff4179a4481233257f5f475ca57ce9061af900 as the
> following circular dependency is created if BR2_PACKAGE_TPM2_TSS_FAPI
> is selected: tpm2-tss -> libcurl -> gnutls -> tmp2-tss
> resulting in the following build failure of libcurl or rtmpdump:
>
> configure: error: TLS not detected, you will not be able to use HTTPS, FTPS, NTLM and more.
> Use --with-openssl, --with-gnutls, --with-wolfssl, --with-mbedtls, --with-schannel, --with-secure-transport, --with-amissl, --with-bearssl or --with-rustls to address this.
>
> [...]
>
> In file included from rtmp.c:32:
> rtmp_sys.h:110:10: fatal error: gnutls/gnutls.h: No such file or directory
> 110 | #include <gnutls/gnutls.h>
> | ^~~~~~~~~~~~~~~~~
>
> Fixes: caff4179a4481233257f5f475ca57ce9061af900
> - http://autobuild.buildroot.org/results/72e1843de650c9ed4795f1141e9fd485b71a14c3
> - http://autobuild.buildroot.org/results/918f0f7efa810b17f6d2266a890bf0150cbed146
Thanks for investigating this issue. One comment below.
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/gnutls/gnutls.mk | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/package/gnutls/gnutls.mk b/package/gnutls/gnutls.mk
> index 8302194812..8a4f3345aa 100644
> --- a/package/gnutls/gnutls.mk
> +++ b/package/gnutls/gnutls.mk
> @@ -57,7 +57,6 @@ HOST_GNUTLS_CONF_OPTS = \
> --without-librt-prefix \
> --without-libz-prefix \
> --without-tpm \
> - --without-tpm2 \
I guess we should leave this here to make it explicit we do not support
tpm2 for host. More importantly, I think we also need unconditional
--without-tpm2 in GNUTLS_CONF_OPTS.
baruch
> --disable-openssl-compatibility \
> --without-libbrotli \
> --without-idn \
> @@ -99,13 +98,6 @@ else
> GNUTLS_CONF_OPTS += --without-p11-kit
> endif
>
> -ifeq ($(BR2_PACKAGE_TPM2_TSS),y)
> -GNUTLS_CONF_OPTS += --with-tpm2
> -GNUTLS_DEPENDENCIES += tpm2-tss
> -else
> -GNUTLS_CONF_OPTS += --without-tpm2
> -endif
> -
> ifeq ($(BR2_PACKAGE_ZLIB),y)
> GNUTLS_CONF_OPTS += --with-zlib
> GNUTLS_DEPENDENCIES += zlib
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-21 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 9:00 [Buildroot] [PATCH 1/1] Revert "package/gnutls: add tpm2-tss optional dependency" Fabrice Fontaine
2024-07-21 9:39 ` Baruch Siach via buildroot [this message]
2024-07-21 16:29 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734o3ozh9.fsf@tarshish \
--to=buildroot@buildroot.org \
--cc=baruch@tkos.co.il \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.