From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8DD7C27C53 for ; Wed, 19 Jun 2024 09:25:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B6C0B88415; Wed, 19 Jun 2024 11:25:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="oX7iQKgr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A95F98842A; Wed, 19 Jun 2024 11:25:44 +0200 (CEST) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C88C587EBD for ; Wed, 19 Jun 2024 11:25:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@baylibre.com Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4230366ad7bso58082325e9.1 for ; Wed, 19 Jun 2024 02:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718789140; x=1719393940; darn=lists.denx.de; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=/11EvVQ8kKo5SBrVwHaYuXlUdXV8yXl7VRqRkP2ef/E=; b=oX7iQKgr0oxV1FcAkDLDEfiSYOgzq6p4qQ7O1vojgZSdYLFtm2THaf5ixk9JPSWlNs vSRPHCBBLJCsMUE4m74DJ7dPhZ7aXUTVP9nciNAVVlkAh7qBswZoPomk7hc3wQAWkrR6 eK12BEjrPt4hVIFlylzAquJ5p3Td19/SOPSk/UIKbemfXyvqCiSUdJ0Esysx0klH93u0 qJNcAIkVTeXcsSlEBMU70evKfuLu+OdJYV8N+AajwUjfTOYEnTOwffPebD3FI9n3qlAK nQZ/X4wGn7vhvul19d7KS/Y3m+tz9/a2yrC9CK5/ECC0vj9EJ5z65blPKI9YffWZevsb 3Www== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718789140; x=1719393940; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/11EvVQ8kKo5SBrVwHaYuXlUdXV8yXl7VRqRkP2ef/E=; b=riFYrNI5ZAsS/RKjWReX/KVcR3Zt5XGltLjl7nIsndq18baJQB1xZs4dJtllT32lk5 9LcNbBhFglgnqyGSEsm6CJvv5Y+/JECyrW34SLC+H1cdVoNpRHk4AoxJdekgoDp4iITq RRluh8+OzwM7zumVXnl1UB9c7LJh1E9nV90r6b6ijWeSh20GxPlDNa+hCSM3c2d7cw7m v6yYSmyPOrwr7h5wq0bMJtaq2B1/6nIXCkrwUN1lpunF9Fq/GzqQGT6OMViQblJcUXKw aofxTTzhYS/WU/wZX44muEajAWZ4MORXdh1uD+aIq4tMxV6jG6hbeetxs9Jp25YQQnHX kF+w== X-Forwarded-Encrypted: i=1; AJvYcCXBMlNTJxLTj6Dv8WjzfdKs4V7i1GuzSS36bhDRQnj+j6ABjGq+2VGTn9nlPoFUctj1EOnQYOhKeQ3ONNUEJ/Bm+lg2Vg== X-Gm-Message-State: AOJu0YxbmQfVlUdReTI/bP2HRg0+oaaWTgT633kVDhdmGJmR71308Mkq xuC9/Y6yX9jP5Az6TxjS/+etQk5N/DZNX6u+4bsrEWfzYezJKfqyywaOqogZhjg= X-Google-Smtp-Source: AGHT+IEhdJq3c7vbNOaD66Rx6Ph0rvFObAnkms7VVmJrQPB/fAnRq5a9tkokOumdC3RoDBNbhQsFWw== X-Received: by 2002:a05:600c:4b27:b0:423:b5f9:203f with SMTP id 5b1f17b1804b1-42475079466mr15075515e9.5.1718789140015; Wed, 19 Jun 2024 02:25:40 -0700 (PDT) Received: from localhost ([2a01:cb19:95ba:5000:d6dd:417f:52ac:335b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42286eef970sm256496515e9.10.2024.06.19.02.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jun 2024 02:25:39 -0700 (PDT) From: Mattijs Korpershoek To: Simon Glass Cc: Julien Masson , Guillaume La Roque , Dmitrii Merkurev , Roman Stratiienko , Igor Opaniuk , u-boot@lists.denx.de Subject: Re: [PATCH v2 0/5] bootstd: Add Android support In-Reply-To: References: <20240613-bootmeth-android-v2-0-397f6e66eb29@baylibre.com> <87o77zbnx3.fsf@baylibre.com> Date: Wed, 19 Jun 2024 11:25:38 +0200 Message-ID: <8734p9b7xp.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Simon. On mar., juin 18, 2024 at 21:03, Simon Glass wrote: > Hi Mattijs, > > On Mon, 17 Jun 2024 at 09:15, Mattijs Korpershoek > wrote: >> >> Hi Simon, >> >> On lun., juin 17, 2024 at 07:53, Simon Glass wrote: >> >> > Hi Mattijs, >> > >> > On Thu, 13 Jun 2024 at 04:13, Mattijs Korpershoek >> > wrote: >> >> >> >> Android boot flow is a bit different than a regular Linux distro. >> >> Android relies on multiple partitions in order to boot. >> >> >> >> A typical boot flow would be: >> >> 1. Parse the Bootloader Control Block (BCB, misc partition) >> >> 2. If BCB requested bootonce-bootloader, start fastboot and wait. >> >> 3. If BCB requested recovery or normal android, run the following: >> >> a. Get slot (A/B) from BCB >> >> b. Run AVB (Android Verified Boot) on boot partitions >> >> c. Load boot and vendor_boot partitions >> >> d. Load device-tree, ramdisk and boot >> >> >> >> The AOSP documentation has more details at [1], [2], [3] >> >> >> >> This has been implemented via complex boot scripts such as [4]. >> >> However, these boot script are neither very maintainable nor generic. >> >> Moreover, DISTRO_DEFAULTS is being deprecated [5]. >> >> >> >> Add a generic Android bootflow implementation for bootstd. >> >> >> >> For this initial version, only boot image v4 is supported. >> >> >> >> This has been tested on sandbox using: >> >> $ ./test/py/test.py --bd sandbox --build -k test_ut >> >> >> >> This has also been tested on the AM62X SK EVM using TI's Android SDK[6] >> >> To test on TI board, the following (WIP) patch is needed as well: >> >> https://gitlab.baylibre.com/baylibre/ti/ti-u-boot/-/commit/84cceb912bccd7cdd7f9dd69bca0e5d987a1fd04 >> >> >> >> [1] https://source.android.com/docs/core/architecture/bootloader >> >> [2] https://source.android.com/docs/core/architecture/partitions >> >> [3] https://source.android.com/docs/core/architecture/partitions/generic-boot >> >> [4] https://source.denx.de/u-boot/u-boot/-/blob/master/include/configs/meson64_android.h >> >> [5] https://lore.kernel.org/r/all/20230914165615.1058529-17-sjg@chromium.org/ >> >> [6] https://software-dl.ti.com/processor-sdk-android/esd/AM62X/09_02_00/docs/android/Overview.html >> >> >> >> Signed-off-by: Mattijs Korpershoek >> >> --- >> >> Changes in v2: >> >> - Dropped patch 2/6 boot: android: Add image_android_get_version() (Igor) >> >> - Fixed multi-line comment style (Igor, Simon) >> >> - Added dependency on CMD_FASTBOOT for BOOTMETH_ANDROID (Igor) >> >> - Fixed various resource leaks (Igor) >> >> - Fixed bootmeth_priv dangling pointer on error cases (Igor) >> >> - Updated test instructions in commit message for patch 6/6 >> >> - Added __weak impl of get_avendor_bootimg_addr() in patch 1 (dropped >> >> Igor's review because of this change) >> >> - Added extra info in Kconfig to detail MMC limitation (Simon) >> >> - Fixed typo Bootmethod->Bootmeth (Simon) >> >> - Documented android_priv structure (Simon) >> >> - Demoted various messages from printf() to log_debug (Simon) >> >> - Fixed some lines too long (Simon) >> >> - Added function documentation to read_slotted_partition() (Simon) >> >> - Added some doc about avb extra_args being modified (Simon) >> >> - Link to v1: https://lore.kernel.org/r/20240606-bootmeth-android-v1-0-0c69d4457cc5@baylibre.com >> >> >> >> --- >> >> Mattijs Korpershoek (5): >> >> boot: android: Provide vendor_bootimg_addr in boot_get_fdt() >> >> bootstd: Add bootflow_iter_check_mmc() helper >> >> android: boot: Add set_abootimg_addr() and set_avendor_bootimg_addr() >> >> bootstd: Add a bootmeth for Android >> >> bootstd: Add test for bootmeth_android >> >> >> >> MAINTAINERS | 7 + >> >> arch/sandbox/dts/test.dts | 8 + >> >> boot/Kconfig | 16 ++ >> >> boot/Makefile | 2 + >> >> boot/bootflow.c | 12 + >> >> boot/bootmeth_android.c | 553 ++++++++++++++++++++++++++++++++++++++++++++++ >> >> boot/bootmeth_android.h | 29 +++ >> >> boot/image-android.c | 5 + >> >> boot/image-fdt.c | 2 +- >> >> cmd/abootimg.c | 10 + >> >> configs/sandbox_defconfig | 2 +- >> >> doc/develop/bootstd.rst | 6 + >> >> include/bootflow.h | 9 + >> >> include/image.h | 14 ++ >> >> test/boot/bootflow.c | 65 +++++- >> >> test/py/tests/test_ut.py | 76 +++++++ >> >> 16 files changed, 811 insertions(+), 5 deletions(-) >> >> --- >> >> base-commit: f9886bc60f42d5bcfcfa4e474af7dc230400b6be >> >> change-id: 20240605-bootmeth-android-bfc8596e9367 >> >> >> >> Best regards, >> >> -- >> >> Mattijs Korpershoek >> >> >> > >> > Thinking about this, I believe we should start having docs about the >> > individual bootmeths themselves. >> >> Yes. >> >> > >> > Can you add a section about your new bootmeth? I will come up with a >> > patch for the others that I know about. Perhaps >> > doc/develop/bootstd.rst would be a suitable place for now? >> >> Yes I can add a section. I would have preferred to have an example to >> work from there, but I can start writing docs as well. >> >> I'm leaving on vacation soon (without computer), so I'll be able to >> send a v3 with docs included in at earliest a 2-3 weeks from now. > > It isn't a blocker for this series, just something I thought of. Understood. In that case if there are no other remarks on this series, I'd prefer to submit a separate documentation patch once this is applied! > >> >> If you make a patch for the other bootmeths in the mean-time, please cc >> me so that I can help review and have an example for Android. > > Yes, will do, if I do. > > Regards, > Simon