From: Ben Walsh <ben@jubnut.com>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: "Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Dustin L. Howett" <dustin@howett.net>,
"Kieran Levin" <ktl@frame.work>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Mario Limonciello" <mario.limonciello@amd.com>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] platform/chrome: cros_ec_lpc: MEC access can use an AML mutex
Date: Thu, 06 Jun 2024 06:23:30 +0100 [thread overview]
Message-ID: <8734pqskz1.fsf@jubnut.com> (raw)
In-Reply-To: <ZmEpOQmzFv7Quakq@google.com>
Tzung-Bi Shih <tzungbi@kernel.org> writes:
> A nit haven't caught in previous round review:
>
> - `if (ret)` for cros_ec_lpc_mec_lock().
> - `if (ret < 0)` for cros_ec_lpc_mec_unlock().
>
> If I see the inconsistency when reading the code, it would take me further
> cycles for seeking why. We should fix it.
>
> No need to resend for this; I will fix it for you.
Oh yes. Thanks very much for fixing, and for reviewing!
next prev parent reply other threads:[~2024-06-06 5:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 6:33 [PATCH v3 0/5] platform/chrome: Fix MEC concurrency problems for Framework Laptop Ben Walsh
2024-06-05 6:33 ` [PATCH v3 1/5] platform/chrome: cros_ec_lpc: MEC access can return error code Ben Walsh
2024-06-05 6:33 ` [PATCH v3 2/5] platform/chrome: cros_ec_lpc: MEC access can use an AML mutex Ben Walsh
2024-06-06 3:12 ` Tzung-Bi Shih
2024-06-06 5:23 ` Ben Walsh [this message]
2024-06-05 6:33 ` [PATCH v3 3/5] platform/chrome: cros_ec_lpc: Add a new quirk for ACPI id Ben Walsh
2024-06-05 6:33 ` [PATCH v3 4/5] platform/chrome: cros_ec_lpc: Add a new quirk for AML mutex Ben Walsh
2024-06-05 6:33 ` [PATCH v3 5/5] platform/chrome: cros_ec_lpc: Add quirks for Framework Laptop Ben Walsh
2024-06-06 3:30 ` [PATCH v3 0/5] platform/chrome: Fix MEC concurrency problems " patchwork-bot+chrome-platform
2024-06-06 3:30 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734pqskz1.fsf@jubnut.com \
--to=ben@jubnut.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dustin@howett.net \
--cc=groeck@chromium.org \
--cc=ktl@frame.work \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mario.limonciello@amd.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.