From: Petr Machata <petrm@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Petr Machata <petrm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>,
Ido Schimmel <idosch@nvidia.com>,
David Ahern <dsahern@kernel.org>, Shuah Khan <shuah@kernel.org>,
<mlxsw@nvidia.com>
Subject: Re: [PATCH net-next 11/11] selftests: forwarding: Add a test for NH group stats
Date: Mon, 11 Mar 2024 17:30:54 +0100 [thread overview]
Message-ID: <8734swlmjh.fsf@nvidia.com> (raw)
In-Reply-To: <20240311085912.5a149182@kernel.org>
Jakub Kicinski <kuba@kernel.org> writes:
> On Mon, 11 Mar 2024 12:00:59 +0100 Petr Machata wrote:
>> > It should run the SW parts and skip the HW ones.
>>
>> In fact why don't I paste the run I still have in the terminal from last
>> week:
>>
>> [root@virtme-ng forwarding]# TESTS=" nh_stats_test_v4 nh_stats_test_v6 " ./router_mpath_nh_res.sh
>> TEST: NH stats test IPv4 [ OK ]
>> TEST: HW stats not offloaded on veth topology [SKIP]
>> TEST: NH stats test IPv6 [ OK ]
>> TEST: HW stats not offloaded on veth topology [SKIP]
>
> SKIP beats PASS so the result for the entire test (according to our
> local result parser) will be SKIP. Can we switch to XFAIL?
Sure.
But I don't think SKIP should trump PASS. IMHO SKIP is the weakest
status, soon as you have one PASS, that's what the overall outcome
should be. I guess the logic behind it was that it's useful to see the
tests that skip?
next prev parent reply other threads:[~2024-03-11 17:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 12:59 [PATCH net-next 00/11] mlxsw: Support for nexthop group statistics Petr Machata
2024-03-08 12:59 ` [PATCH net-next 01/11] net: nexthop: Initialize NH group ID in resilient NH group notifiers Petr Machata
2024-03-08 12:59 ` [PATCH net-next 02/11] net: nexthop: Have all NH notifiers carry NH ID Petr Machata
2024-03-08 12:59 ` [PATCH net-next 03/11] mlxsw: spectrum_router: Rename two functions Petr Machata
2024-03-08 12:59 ` [PATCH net-next 04/11] mlxsw: spectrum_router: Have mlxsw_sp_nexthop_counter_enable() return int Petr Machata
2024-03-08 12:59 ` [PATCH net-next 05/11] mlxsw: spectrum: Allow fetch-and-clear of flow counters Petr Machata
2024-03-08 12:59 ` [PATCH net-next 06/11] mlxsw: spectrum_router: Avoid allocating NH counters twice Petr Machata
2024-03-08 12:59 ` [PATCH net-next 07/11] mlxsw: spectrum_router: Add helpers for nexthop counters Petr Machata
2024-03-08 12:59 ` [PATCH net-next 08/11] mlxsw: spectrum_router: Track NH ID's of group members Petr Machata
2024-03-08 12:59 ` [PATCH net-next 09/11] mlxsw: spectrum_router: Support nexthop group hardware statistics Petr Machata
2024-03-08 12:59 ` [PATCH net-next 10/11] mlxsw: spectrum_router: Share nexthop counters in resilient groups Petr Machata
2024-03-08 12:59 ` [PATCH net-next 11/11] selftests: forwarding: Add a test for NH group stats Petr Machata
2024-03-08 17:03 ` Jakub Kicinski
2024-03-08 22:31 ` Petr Machata
2024-03-09 3:48 ` Jakub Kicinski
2024-03-09 4:47 ` David Ahern
2024-03-11 10:59 ` Petr Machata
2024-03-11 11:00 ` Petr Machata
2024-03-11 15:59 ` Jakub Kicinski
2024-03-11 16:30 ` Petr Machata [this message]
2024-03-11 17:52 ` Jakub Kicinski
2024-03-11 22:00 ` [PATCH net-next 00/11] mlxsw: Support for nexthop group statistics patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734swlmjh.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.