From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Riana Tauro <riana.tauro@intel.com>
Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>,
intel-xe@lists.freedesktop.org, vivi.rodrigo@intel.com
Subject: Re: [Intel-xe] [RFC 1/4] drm/xe: Moving and renaming existing frequency sysfs attributes
Date: Mon, 20 Nov 2023 20:58:17 -0800 [thread overview]
Message-ID: <8734wz7lee.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <27e7aba4-6048-4023-ae71-f1501bca570d@intel.com>
On Mon, 20 Nov 2023 20:50:00 -0800, Riana Tauro wrote:
>
> > @@ -950,6 +950,7 @@ int xe_guc_pc_init(struct xe_guc_pc *pc)
> > struct xe_tile *tile = gt_to_tile(gt);
> > struct xe_device *xe = gt_to_xe(gt);
> > struct xe_bo *bo;
> > + struct kobject *kobj;
> > u32 size = PAGE_ALIGN(sizeof(struct slpc_shared_data));
> > int err;
> > @@ -965,7 +966,9 @@ int xe_guc_pc_init(struct xe_guc_pc *pc)
> > pc->bo = bo;
> > - err = sysfs_create_files(gt->sysfs, pc_attrs);
> > + kobj = kobject_create_and_add("freq", gt->sysfs);
> Handle error here
> > +
> > + err = sysfs_create_files(kobj, pc_attrs); > if (err)
> add kobject put if creating files returns error
>
> also clean up on finish
These are needed too but won't fix the kernel crash. Look at existing sysfs
functions, at least i915 has those.
Hint: the issue is creating the new freq directory.
next prev parent reply other threads:[~2023-11-21 4:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 14:30 [Intel-xe] [RFC 0/4] Adding new frequency sysfs attributes Sujaritha Sundaresan
2023-11-16 14:20 ` [Intel-xe] ✗ CI.Patch_applied: failure for " Patchwork
2023-11-16 14:30 ` [Intel-xe] [RFC 1/4] drm/xe: Moving and renaming existing " Sujaritha Sundaresan
2023-11-21 4:12 ` Dixit, Ashutosh
2023-11-21 4:50 ` Riana Tauro
2023-11-21 4:58 ` Dixit, Ashutosh [this message]
2023-11-22 8:25 ` Sundaresan, Sujaritha
2023-11-22 14:32 ` Gupta, Anshuman
2023-11-16 14:30 ` [Intel-xe] [RFC 2/4] drm/xe: Add memory directory for vram attributes Sujaritha Sundaresan
2023-11-17 21:37 ` Rodrigo Vivi
2023-11-18 1:25 ` Welty, Brian
2023-11-22 8:36 ` Sundaresan, Sujaritha
2023-11-22 8:37 ` Sundaresan, Sujaritha
2023-11-16 14:30 ` [Intel-xe] [RFC 3/4] drm/xe: Add throttle reasons sysfs attributes Sujaritha Sundaresan
2023-11-17 21:41 ` Rodrigo Vivi
2023-11-20 3:33 ` Sundaresan, Sujaritha
2023-11-22 8:33 ` Sundaresan, Sujaritha
2023-11-16 14:30 ` [Intel-xe] [RFC 4/4] drm/xe: Add vram frequency " Sujaritha Sundaresan
2023-11-17 21:43 ` Rodrigo Vivi
2023-11-18 2:24 ` [Intel-xe] ✓ CI.Patch_applied: success for Adding new " Patchwork
2023-11-18 2:24 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-11-18 2:25 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-11-18 2:32 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-11-18 2:33 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-11-18 2:34 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-11-18 3:12 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734wz7lee.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=riana.tauro@intel.com \
--cc=sujaritha.sundaresan@intel.com \
--cc=vivi.rodrigo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.