All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: <johannes@sipsolutions.net>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 5/6] wifi: radiotap: add bandwidth definition of EHT U-SIG
Date: Tue, 10 Oct 2023 09:20:03 +0300	[thread overview]
Message-ID: <8734yj578s.fsf@kernel.org> (raw)
In-Reply-To: <20231010021006.6061-6-pkshih@realtek.com> (Ping-Ke Shih's message of "Tue, 10 Oct 2023 10:10:05 +0800")

Ping-Ke Shih <pkshih@realtek.com> writes:

> Define EHT U-SIG bandwidth used by radiotap according to Table 36-28
> "U-SIG field of an EHT MU PPDU" in 802.11be (D3.0).
>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> v2:
>   - correct commit message about the source of bandwidth definition
>     of EHT U-SIG suggested by Johannes
> ---
>  include/net/ieee80211_radiotap.h | 6 ++++++
>  1 file changed, 6 insertions(+)

This is nitpicking but in general it's good to have the patches touching
files outside of drivers/net/wireless in the beginning of the patchset
to make them more visible. No need to resend because of this, just a
small tip.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-10-10  6:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10  2:10 [PATCH v2 0/6] wifi: rtw89: handle EHT rate Ping-Ke Shih
2023-10-10  2:10 ` [PATCH v2 1/6] wifi: rtw89: parse EHT information from RX descriptor and PPDU status packet Ping-Ke Shih
2023-10-10  2:10 ` [PATCH v2 2/6] wifi: rtw89: Add EHT rate mask as parameters of RA H2C command Ping-Ke Shih
2023-10-10  2:10 ` [PATCH v2 3/6] wifi: rtw89: parse TX EHT rate selected by firmware from RA C2H report Ping-Ke Shih
2023-10-10  2:10 ` [PATCH v2 4/6] wifi: rtw89: show EHT rate in debugfs Ping-Ke Shih
2023-10-10  2:10 ` [PATCH v2 5/6] wifi: radiotap: add bandwidth definition of EHT U-SIG Ping-Ke Shih
2023-10-10  6:20   ` Kalle Valo [this message]
2023-10-11  0:54     ` Ping-Ke Shih
2023-10-10  2:10 ` [PATCH v2 6/6] wifi: rtw89: add EHT radiotap in monitor mode Ping-Ke Shih
2023-10-11  9:13   ` Kalle Valo
2023-10-11  9:19     ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734yj578s.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.