Re: [PATCH] wifi: rtlwifi: rtl8192cu: Remove driver

[Kalle Valo <kvalo@kernel.org>]

Larry Finger <Larry.Finger@lwfinger.net> writes:

> On 4/29/23 04:42, Martin Kaistra wrote:
>> Am 28.04.23 um 20:29 schrieb Larry Finger:
>>> The functionality of these devices has been replaced by the rtl8xxxu
>>> driver, thus the version under rtlwifi can be removed.
>>>
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>
>> Things to keep in mind:
>> - rtlwifi offers AP mode support for rtl8192cu devices, rtl8xxxu
>> doesn't (yet) do that. Should be relatively easy to add that on top
>> of [1], though.
>> - The rtl8192cu devices are currently hidden behind
>> CONFIG_RTL8XXXU_UNTESTED in the rtl8xxxu driver with the comment
>> "Still supported by rtlwifi".
>>
>>
>> [1]
>> https://lore.kernel.org/linux-wireless/20230428150833.218605-1-martin.kaistra@linutronix.de/
>
> Kalle,
>
> I failed to consider this point. Please drop my patch. Instead, I will
> submit one to remove that configuration parameter that says the
> rtl8192cu is "untested".

The original reason why we added CONFIG_RTL8XXXU_UNTESTED back in the
day was so that we would not have two drivers supporting the same
hardware. Though I don't know how much the kconfig helped with that but
at least the conflicts were somehow documented.

Now that rtl8xxxu has matured and gained more features, I would really
like the idea of removing rtl8192cu driver. Of course we should make
sure that we are not accidentally removing any devices support, for
example I was not able to find this device in rtl8xxxu:

	{RTL_USB_DEVICE(USB_VENDOR_ID_REALTEK, 0x817c, rtl92cu_hal_cfg)},

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches